Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2583483003:
Add testing spec and mb config for unswarmed android trybots. (Closed)
DescriptionAdd testing spec and mb config for unswarmed android trybots.
Also add mb config for swarmed 64bit dbg tester.
Build-side change: https://chromium-review.googlesource.com/c/420415/
BUG=670101
Committed: https://crrev.com/aca61339682f9d60be8d68e70d58c294ff531990
Cr-Commit-Position: refs/heads/master@{#439560}
Patch Set 1 #
Total comments: 6
Patch Set 2 : timeout scale #Patch Set 3 : also add telemetry_perf_unittests #Patch Set 4 : rebase? #Messages
Total messages: 21 (10 generated)
Description was changed from ========== Add testing spec and mb config for unswarmed android trybots. Also add mb config for swarmed 64bit dbg tester. BUG=670101 ========== to ========== Add testing spec and mb config for unswarmed android trybots. Also add mb config for swarmed 64bit dbg tester. Build-side change: https://chromium-review.googlesource.com/c/420415/ BUG=670101 ==========
bpastene@chromium.org changed reviewers: + dpranke@chromium.org, jbudorick@chromium.org, stip@chromium.org
lgtm
https://codereview.chromium.org/2583483003/diff/1/testing/buildbot/chromium.a... File testing/buildbot/chromium.android.fyi.json (right): https://codereview.chromium.org/2583483003/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.fyi.json:352: "swarming": { Are these necessary? https://codereview.chromium.org/2583483003/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.fyi.json:531: "timeout_scale": 4 These should not need a timeout scale. https://codereview.chromium.org/2583483003/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.fyi.json:736: "timeout_scale": 4 Nor should these.
https://codereview.chromium.org/2583483003/diff/1/testing/buildbot/chromium.a... File testing/buildbot/chromium.android.fyi.json (right): https://codereview.chromium.org/2583483003/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.fyi.json:352: "swarming": { On 2016/12/16 01:14:22, jbudorick wrote: > Are these necessary? Don't ask me. Ask this script that runs on presubmit: https://chromium.googlesource.com/chromium/src/+/7121b312765ed1d43a570aa69559... https://codereview.chromium.org/2583483003/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.fyi.json:531: "timeout_scale": 4 On 2016/12/16 01:14:22, jbudorick wrote: > These should not need a timeout scale. Done. https://codereview.chromium.org/2583483003/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.fyi.json:736: "timeout_scale": 4 On 2016/12/16 01:14:22, jbudorick wrote: > Nor should these. Done.
Ping @ jbudorick
lgtm
The CQ bit was checked by bpastene@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2583483003/#ps40001 (title: "also add telemetry_perf_unittests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by bpastene@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/2583483003/#ps60001 (title: "rebase?")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482176068022360,
"parent_rev": "3ec60027208d9ecce1dbaef2271617e5d48e9429", "commit_rev":
"feedc42c1c9ebced8295f779d277b20688a0ffcf"}
Message was sent while issue was closed.
Description was changed from ========== Add testing spec and mb config for unswarmed android trybots. Also add mb config for swarmed 64bit dbg tester. Build-side change: https://chromium-review.googlesource.com/c/420415/ BUG=670101 ========== to ========== Add testing spec and mb config for unswarmed android trybots. Also add mb config for swarmed 64bit dbg tester. Build-side change: https://chromium-review.googlesource.com/c/420415/ BUG=670101 Review-Url: https://codereview.chromium.org/2583483003 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add testing spec and mb config for unswarmed android trybots. Also add mb config for swarmed 64bit dbg tester. Build-side change: https://chromium-review.googlesource.com/c/420415/ BUG=670101 Review-Url: https://codereview.chromium.org/2583483003 ========== to ========== Add testing spec and mb config for unswarmed android trybots. Also add mb config for swarmed 64bit dbg tester. Build-side change: https://chromium-review.googlesource.com/c/420415/ BUG=670101 Committed: https://crrev.com/aca61339682f9d60be8d68e70d58c294ff531990 Cr-Commit-Position: refs/heads/master@{#439560} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/aca61339682f9d60be8d68e70d58c294ff531990 Cr-Commit-Position: refs/heads/master@{#439560} |
