Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2583453002: Enable strong-mode test suite for dartk. (Closed)

Created:
4 years ago by asgerf
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable strong-mode test suite for dartk. This adds status files for skipping tests that are not yet strong, and a status file with the tests that fail with the dartk-vm configuration. To test: tools/test.py -cdartk --strong {language,lib,corelib}_strong BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/31d5860c81aa41441f028c4affb80e237e1bd1b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1327 lines, -0 lines) Patch
A tests/corelib_strong/corelib_strong.status View 1 chunk +56 lines, -0 lines 0 comments Download
A tests/corelib_strong/corelib_strong_kernel.status View 1 chunk +36 lines, -0 lines 0 comments Download
A tests/language_strong/language_strong.status View 1 chunk +683 lines, -0 lines 0 comments Download
A tests/language_strong/language_strong_kernel.status View 1 chunk +161 lines, -0 lines 0 comments Download
A tests/lib_strong/lib_strong.status View 1 chunk +132 lines, -0 lines 0 comments Download
A tests/lib_strong/lib_strong_kernel.status View 1 chunk +256 lines, -0 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
asgerf
4 years ago (2016-12-15 11:02:53 UTC) #3
Kevin Millikin (Google)
LGTM
4 years ago (2016-12-15 11:20:56 UTC) #4
asgerf
4 years ago (2016-12-15 11:50:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
31d5860c81aa41441f028c4affb80e237e1bd1b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698