Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2583423002:
remove suppression for WebGL2 conformance2/glsl3/float-parsing.html (Closed)
Descriptionremove suppression for WebGL2 conformance2/glsl3/float-parsing.html
BUG=672722
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true
Committed: https://crrev.com/71b4efd9b846058cbf7c882af1137676962614a1
Cr-Commit-Position: refs/heads/master@{#440251}
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== suppress webgl 2 conformance test BUG=672722 ========== to ========== suppress webgl 2 conformance test BUG=672722 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Description was changed from ========== suppress webgl 2 conformance test BUG=672722 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== suppress webgl 2 conformance test for float-parsing.html BUG=672722 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
yunchao.he@intel.com changed reviewers: + kainino@chromium.org, kbr@chromium.org, zmo@chromium.org
PTAL. Thanks a lot!
Description was changed from ========== suppress webgl 2 conformance test for float-parsing.html BUG=672722 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== remove suppression for WebGL2 conformance2/glsl3/float-parsing.html BUG=672722 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
On 2016/12/20 08:49:48, yunchao wrote: > PTAL. Thanks a lot! I updated your description to be more precise. Non-owner LGTM.
On 2016/12/20 17:53:36, Kai Ninomiya wrote: > On 2016/12/20 08:49:48, yunchao wrote: > > PTAL. Thanks a lot! > > I updated your description to be more precise. Non-owner LGTM. Thanks, Kai. Could you take a look, Zhenyao and/or Ken?
The CQ bit was checked by kbr@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
On 2016/12/21 22:38:06, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...) Sorry, that bot's broken right now per http://crbug.com/673475 . Let me NOTRY= this for you.
Description was changed from ========== remove suppression for WebGL2 conformance2/glsl3/float-parsing.html BUG=672722 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== remove suppression for WebGL2 conformance2/glsl3/float-parsing.html BUG=672722 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482360067884360, "parent_rev":
"7cb61ace4f90701ef3c6925997cfcb982d0b0efd", "commit_rev":
"140d9743ef27f025a8ca0ca305a0751c629f4380"}
Message was sent while issue was closed.
Description was changed from ========== remove suppression for WebGL2 conformance2/glsl3/float-parsing.html BUG=672722 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true ========== to ========== remove suppression for WebGL2 conformance2/glsl3/float-parsing.html BUG=672722 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true Review-Url: https://codereview.chromium.org/2583423002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== remove suppression for WebGL2 conformance2/glsl3/float-parsing.html BUG=672722 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true Review-Url: https://codereview.chromium.org/2583423002 ========== to ========== remove suppression for WebGL2 conformance2/glsl3/float-parsing.html BUG=672722 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/71b4efd9b846058cbf7c882af1137676962614a1 Cr-Commit-Position: refs/heads/master@{#440251} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/71b4efd9b846058cbf7c882af1137676962614a1 Cr-Commit-Position: refs/heads/master@{#440251}
Message was sent while issue was closed.
On 2016/12/21 22:40:58, Ken Russell wrote: > On 2016/12/21 22:38:06, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...) > > Sorry, that bot's broken right now per http://crbug.com/673475 . Let me NOTRY= > this for you. Thank you, Ken. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
