Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2583413002: Fix layout test editing/spelling/context_click_select_misspelling.html (Closed)

Created:
4 years ago by Xiaocheng
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix layout test editing/spelling/context_click_select_misspelling.html For a spellcheck test, sample should be removed after the test passes. This patch ensures sample removal for the above mentioned layout test. This patch is also a preparation for idle time spell checker because it relies on visibility, while unremoved samples affect visibility of other tests. BUG=517298 Committed: https://crrev.com/477ef171bbd8a21249a65d28b4693552a0a1def9 Cr-Commit-Position: refs/heads/master@{#439709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/context_click_select_misspelling.html View 5 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Xiaocheng
PTAL.
4 years ago (2016-12-20 03:30:28 UTC) #5
tkent
lgtm
4 years ago (2016-12-20 03:57:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583413002/1
4 years ago (2016-12-20 04:48:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 04:53:07 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 04:55:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/477ef171bbd8a21249a65d28b4693552a0a1def9
Cr-Commit-Position: refs/heads/master@{#439709}

Powered by Google App Engine
This is Rietveld 408576698