courgette/disassembler_elf_32.h - Issue 2583373002: [Courgette] Simple AssemblyProgram and Disassembler cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/disassembler_elf_32.h

Issue 2583373002: [Courgette] Simple AssemblyProgram and Disassembler cleanups. (Closed)

Patch Set: Tune up header inclusion. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: courgette/disassembler_elf_32.h

diff --git a/courgette/disassembler_elf_32.h b/courgette/disassembler_elf_32.h

index 395f571e0bf1929ad76584c5f31e94dd64114111..3cf42e2e546107433cf7d4d9c411fe7bd7ed7b9f 100644

--- a/courgette/disassembler_elf_32.h

+++ b/courgette/disassembler_elf_32.h

@@ -104,8 +104,9 @@ class DisassemblerElf32 : public Disassembler {

FileOffset RVAToFileOffset(RVA rva) const override;

RVA PointerToTargetRVA(const uint8_t* p) const override;

ExecutableType kind() const override = 0;

+ uint64_t image_base() const override { return 0; }

bool ParseHeader() override;

- bool Disassemble(AssemblyProgram* target) override;

+ bool Disassemble(AssemblyProgram* program) override;

virtual e_machine_values ElfEM() const = 0;

« no previous file with comments | « courgette/disassembler.h ('k') | courgette/disassembler_elf_32.cc » ('j') | no next file with comments »