courgette/program_detector.cc - Issue 2583373002: [Courgette] Simple AssemblyProgram and Disassembler cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/program_detector.cc

Issue 2583373002: [Courgette] Simple AssemblyProgram and Disassembler cleanups. (Closed)

Patch Set: Sync. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: courgette/program_detector.cc

diff --git a/courgette/program_detector.cc b/courgette/program_detector.cc

index 71021cc3f7a397a78457609c223d7cd3e32cf88a..4c6b2bd0e4408793748f8023e7754983c5c74e5d 100644

--- a/courgette/program_detector.cc

+++ b/courgette/program_detector.cc

@@ -77,7 +77,7 @@ Status ParseDetectedExecutable(const uint8_t* buffer,

return C_INPUT_NOT_RECOGNIZED;

std::unique_ptr<AssemblyProgram> program(

- new AssemblyProgram(disassembler->kind()));

+ new AssemblyProgram(disassembler->kind(), disassembler->image_base()));

grt (UTC plus 2) 2017/01/12 11:56:41 base::MakeUnique

huangs 2017/01/12 19:54:42 Done.

if (!disassembler->Disassemble(program.get()))

return C_DISASSEMBLY_FAILED;

« courgette/disassembler_win32.cc ('K') | « courgette/disassembler_win32.cc ('k') | no next file » | no next file with comments »