Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2835)

Unified Diff: courgette/disassembler_win32.cc

Issue 2583373002: [Courgette] Simple AssemblyProgram and Disassembler cleanups. (Closed)
Patch Set: Sync. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: courgette/disassembler_win32.cc
diff --git a/courgette/disassembler_win32.cc b/courgette/disassembler_win32.cc
index c2824397e6780b3127546c588c9905a93926b80e..5b94ea0af940df7e52fee7cc1c9d2c7271506b1e 100644
--- a/courgette/disassembler_win32.cc
+++ b/courgette/disassembler_win32.cc
@@ -224,26 +224,24 @@ bool DisassemblerWin32::ParseHeader() {
return Good();
}
-bool DisassemblerWin32::Disassemble(AssemblyProgram* target) {
+bool DisassemblerWin32::Disassemble(AssemblyProgram* program) {
if (!ok())
return false;
- target->set_image_base(image_base());
-
if (!ParseAbs32Relocs())
return false;
ParseRel32RelocsFromSections();
- PrecomputeLabels(target);
- RemoveUnusedRel32Locations(target);
+ PrecomputeLabels(program);
+ RemoveUnusedRel32Locations(program);
- if (!target->GenerateInstructions(
+ if (!program->GenerateInstructions(
base::Bind(&DisassemblerWin32::ParseFile, base::Unretained(this)))) {
return false;
}
- target->DefaultAssignIndexes();
+ program->DefaultAssignIndexes();
return true;
}

Powered by Google App Engine
This is Rietveld 408576698