Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: courgette/disassembler_elf_32_x86_unittest.cc

Issue 2583373002: [Courgette] Simple AssemblyProgram and Disassembler cleanups. (Closed)
Patch Set: Sync. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: courgette/disassembler_elf_32_x86_unittest.cc
diff --git a/courgette/disassembler_elf_32_x86_unittest.cc b/courgette/disassembler_elf_32_x86_unittest.cc
index 29304219d78e7c59dc95bc14ca74abd6ca8c2986..18c7b797bf9e02ccfac86f332d8b6eea159e03ad 100644
--- a/courgette/disassembler_elf_32_x86_unittest.cc
+++ b/courgette/disassembler_elf_32_x86_unittest.cc
@@ -89,7 +89,8 @@ void DisassemblerElf32X86Test::TestExe(const char* file_name,
EXPECT_EQ('L', offset_p[2]);
EXPECT_EQ('F', offset_p[3]);
- std::unique_ptr<AssemblyProgram> program(new AssemblyProgram(EXE_ELF_32_X86));
+ std::unique_ptr<AssemblyProgram> program(
grt (UTC plus 2) 2017/01/12 11:56:41 auto program = base::MakeUnique<...>(...); (may as
huangs 2017/01/12 19:54:42 Done.
+ new AssemblyProgram(EXE_ELF_32_X86, 0));
EXPECT_TRUE(disassembler->Disassemble(program.get()));

Powered by Google App Engine
This is Rietveld 408576698