Chromium Code Reviews| Index: components/browser_watcher/stability_report.proto |
| diff --git a/components/browser_watcher/stability_report.proto b/components/browser_watcher/stability_report.proto |
| index 11345c3d0045814f97ad2599c570b45e6839f4af..e3801a3194d7375fbe3b4da6668697370dafc929 100644 |
| --- a/components/browser_watcher/stability_report.proto |
| +++ b/components/browser_watcher/stability_report.proto |
| @@ -51,8 +51,29 @@ message CodeModule { |
| optional string version = 7; |
| } |
| -// An activity represents information about something of interest on a thread. |
| +// A typed value holds values of interest or references to such values. |
| // Next id: 9 |
| +message TypedValue { |
| + // A reference to a value of interest. |
| + message Reference { |
| + optional uint64 address = 1; |
| + optional int64 size = 2; |
| + } |
| + |
| + oneof value { |
| + bytes bytes_value = 1; |
| + Reference bytes_reference = 2; |
| + string string_value = 3; |
| + Reference string_reference = 4; |
| + string char_value = 5; |
| + bool bool_value = 6; |
| + int64 signed_value = 7; |
| + int64 unsigned_value = 8; |
|
bcwhite
2016/12/22 17:21:58
Unsigned?
manzagop (departed)
2017/01/10 14:11:22
Done.
|
| + } |
| +} |
| + |
| +// An activity represents information about something of interest on a thread. |
| +// Next id: 10 |
| message Activity { |
| enum Type { |
| UNKNOWN = 0; |
| @@ -89,6 +110,9 @@ message Activity { |
| // A unique identifier for a process. |
| optional int64 process_id = 8; |
| + |
| + // A key-value store. |
| + map<string, TypedValue> user_data = 9; |
| } |
| // The state of a thread. |
| @@ -122,7 +146,7 @@ message ProcessState { |
| // A stability report contains information pertaining to the execution of a |
| // single logical instance of a "chrome browser". It is comprised of information |
| // about the system state and about the chrome browser's processes. |
| -// Next id: 4 |
| +// Next id: 5 |
| message StabilityReport { |
| optional SystemState system_state = 1; |
| // TODO(manzagop): revisit whether a single repeated field should contain all |
| @@ -134,4 +158,5 @@ message StabilityReport { |
| // TODO(manzagop): if/when reports contain multiple processes, attribute and |
| // relocate these to their process (and perhaps thread). |
| repeated string log_messages = 3; |
| + map<string, TypedValue> global_data = 4; |
| } |