Collect stability data from global and activity scopes

components/browser_watcher/stability_report.proto

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
 package browser_watcher;
 
@@ skipping 33 matching lines @@
   // specific version and build of the associated debug file.  This may be
   // the same as code_identifier when the debug_file and code_file are
   // identical or when the same identifier is used to identify distinct
   // debug and code files.
   optional string debug_identifier = 6;
 
   // A human-readable representation of the code module's version.
   optional string version = 7;
 }
 
+// A typed value holds values of interest or references to such values.
+// Next id: 9
+message TypedValue {
+  // A reference to a value of interest.
+  message Reference {
+    optional uint64 address = 1;
+    optional int64 size = 2;
+  }
+
+  oneof value {
+    bytes bytes_value = 1;
+    Reference bytes_reference = 2;
+    string string_value = 3;
+    Reference string_reference = 4;
+    string char_value = 5;
+    bool bool_value = 6;
+    int64 signed_value = 7;
+    int64 unsigned_value = 8;

[bcwhite, 2016/12/22 17:21:58]

Unsigned?

[manzagop (departed), 2017/01/10 14:11:22]

Done.

+  }
+}
+
 // An activity represents information about something of interest on a thread.
-// Next id: 9
+// Next id: 10
 message Activity {
   enum Type {
     UNKNOWN = 0;
     ACT_TASK_RUN = 1;
     ACT_LOCK_ACQUIRE = 2;
     ACT_EVENT_WAIT = 3;
     ACT_THREAD_JOIN = 4;
     ACT_PROCESS_WAIT = 5;
   }
 
@@ skipping 16 matching lines @@
   optional uint64 lock_address = 5;
 
   // The memory address of the event object.
   optional uint64 event_address = 6;
 
   // A unique identifier for a thread within a process.
   optional int64 thread_id = 7;
 
   // A unique identifier for a process.
   optional int64 process_id = 8;
+
+  // A key-value store.
+  map<string, TypedValue> user_data = 9;
 }
 
 // The state of a thread.
 // Next id: 5
 message ThreadState {
   // The name of the thread, up to a maxiumum length.
   optional string thread_name = 1;
 
   // The identifier of the thread.
   optional int64 thread_id = 2;
@@ skipping 13 matching lines @@
   // Note: likely only a subset of modules of interest (e.g. Chromium's own
   // modules).
   repeated CodeModule modules = 1;
   repeated ThreadState threads = 2;
   // TODO(manzagop): add experiment state.
 }
 
 // A stability report contains information pertaining to the execution of a
 // single logical instance of a "chrome browser". It is comprised of information
 // about the system state and about the chrome browser's processes.
-// Next id: 4
+// Next id: 5
 message StabilityReport {
   optional SystemState system_state = 1;
   // TODO(manzagop): revisit whether a single repeated field should contain all
   //     processes, or whether it's preferable to have separate fields per type.
   // TODO(manzagop): add information about the type of process, pid, process
   //     times (e.g. start time), hierarchical relationships (e.g. parent pid),
   //     command line, etc.
   repeated ProcessState process_states = 2;
   // TODO(manzagop): if/when reports contain multiple processes, attribute and
   //     relocate these to their process (and perhaps thread).
   repeated string log_messages = 3;
+  map<string, TypedValue> global_data = 4;
 }