[chromecast] Adds MediaSinkDefault.

[chromecast] Adds MediaSinkDefault.

The new sink incorporates media duration for EOS notification. Previously
the default backed fired the EOS notification as soon as it received the
EOS buffer, which made the media playback to end much sooner than expected.

BUG=internal b/33274894

Review-Url: https://codereview.chromium.org/2583213003
Cr-Commit-Position: refs/heads/master@{#441724}
Committed: https://chromium.googlesource.com/chromium/src/+/15467bee60a407bbdf1774176a03bfcab38be05a

[alokp, 2016-12-19 19:54:37]

The CQ bit was checked by alokp@chromium.org to run a CQ dry run

[alokp, 2016-12-19 19:54:51]

alokp@chromium.org changed reviewers:
+ halliwell@chromium.org, kmackay@chromium.org

[commit-bot: I haz the power, 2016-12-19 19:55:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 20:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 20:41:37]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[alokp, 2016-12-19 21:59:32]

Please hold off the review. AudioVideoPipelineDeviceTest uncovered a few issues
with the patch.

[alokp, 2016-12-20 06:20:00]

On 2016/12/19 21:59:32, alokp wrote:
> Please hold off the review. AudioVideoPipelineDeviceTest uncovered a few
issues
> with the patch.

Ken: The tests are failing because the new backend does not satisfy the
requirement stated here:

https://cs.chromium.org/chromium/src/chromecast/media/cma/backend/audio_video...

"// Call Start() with an initial PTS of 1 second, to test the behaviour if
// we push buffers with a PTS before the start PTS. In this case the backend
// should report the PTS as no later than the last pushed buffers."

Are you sure if this is the correct behavior? I do not infer this from the
current documentation. I understand that the backend would not advance the
current PTS until it receives a buffer containing the start PTS, but I do not
see why the reported PTS needs to be related to pushed buffers.

The upstream media pipeline implementation continues to report start pts until
it receives a buffer that can be rendered. This seems more reasonable behavior
to me.

[alokp, 2017-01-04 22:50:25]

Description was changed from

==========
Adds NullSink that incorporates media duration for EOS notification.

BUG=internal b/33274894
==========

to

==========
[chromecast] Adds MediaSinkDefault.

The new sink incorporates media duration for EOS notification. Previously
the default backed fired the EOS notification as soon as it received the
EOS buffer, which made the media playback to end much sooner than expected.

BUG=internal b/33274894
==========

[alokp, 2017-01-04 22:50:47]

Description was changed from

==========
[chromecast] Adds MediaSinkDefault.

The new sink incorporates media duration for EOS notification. Previously
the default backed fired the EOS notification as soon as it received the
EOS buffer, which made the media playback to end much sooner than expected.

BUG=internal b/33274894
==========

to

==========
[chromecast] Adds MediaSinkDefault.

The new sink incorporates media duration for EOS notification. Previously
the default backed fired the EOS notification as soon as it received the
EOS buffer, which made the media playback to end much sooner than expected.

BUG=internal b/33274894
==========

[alokp, 2017-01-04 22:52:31]

This is ready for review. I have avoided breaking the tests by implementing the
(incorrect) behavior expected by the tests for now. I also filed a bug to fix
those issues when we are ready to roll the next version of CMA backend.

[halliwell, 2017-01-05 17:15:18]

On 2017/01/04 22:52:31, alokp wrote:
> This is ready for review. I have avoided breaking the tests by implementing
the
> (incorrect) behavior expected by the tests for now. I also filed a bug to fix
> those issues when we are ready to roll the next version of CMA backend.

lgtm

[alokp, 2017-01-05 18:10:00]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:10:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 19:25:46]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483639800141820,
"parent_rev": "45cc9079ce70043ea3c2a051ba24b69e0ebd2b3a", "commit_rev":
"15467bee60a407bbdf1774176a03bfcab38be05a"}

[commit-bot: I haz the power, 2017-01-05 19:26:14]

Description was changed from

==========
[chromecast] Adds MediaSinkDefault.

The new sink incorporates media duration for EOS notification. Previously
the default backed fired the EOS notification as soon as it received the
EOS buffer, which made the media playback to end much sooner than expected.

BUG=internal b/33274894
==========

to

==========
[chromecast] Adds MediaSinkDefault.

The new sink incorporates media duration for EOS notification. Previously
the default backed fired the EOS notification as soon as it received the
EOS buffer, which made the media playback to end much sooner than expected.

BUG=internal b/33274894

Review-Url: https://codereview.chromium.org/2583213003
Cr-Commit-Position: refs/heads/master@{#441724}
Committed:
https://chromium.googlesource.com/chromium/src/+/15467bee60a407bbdf1774176a03...
==========

[commit-bot: I haz the power, 2017-01-05 19:26:15]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/15467bee60a407bbdf1774176a03...