Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2583113002: Use preexisting SharedFunctionInfos in the asm-wasm builder (Closed)

Created:
4 years ago by jochen (gone - plz use gerrit)
Modified:
4 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use preexisting SharedFunctionInfos in the asm-wasm builder BUG=chromium:675114 R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2583113002 Cr-Commit-Position: refs/heads/master@{#41796} Committed: https://chromium.googlesource.com/v8/v8/+/58247e87be6a0c5f0bc021c9f329977f5765fe30

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -37 lines) Patch
M src/asmjs/asm-js.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/asmjs/asm-js.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/asmjs/asm-wasm-builder.h View 3 chunks +3 lines, -10 lines 0 comments Download
M src/asmjs/asm-wasm-builder.cc View 1 6 chunks +17 lines, -20 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
jochen (gone - plz use gerrit)
4 years ago (2016-12-19 09:51:18 UTC) #1
titzer
lgtm https://codereview.chromium.org/2583113002/diff/1/src/asmjs/asm-wasm-builder.cc File src/asmjs/asm-wasm-builder.cc (right): https://codereview.chromium.org/2583113002/diff/1/src/asmjs/asm-wasm-builder.cc#newcode144 src/asmjs/asm-wasm-builder.cc:144: Handle<SharedFunctionInfo> shared = Compiler::GetSharedFunctionInfo( Can you rewrite the ...
4 years ago (2016-12-19 10:07:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583113002/20001
4 years ago (2016-12-19 10:56:56 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-19 11:33:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/58247e87be6a0c5f0bc021c9f329977f576...

Powered by Google App Engine
This is Rietveld 408576698