Add CFX_RetainPtr Leak() and Unleak() methods

core/fxcrt/cfx_retain_ptr.h

Index: core/fxcrt/cfx_retain_ptr.h
diff --git a/core/fxcrt/cfx_retain_ptr.h b/core/fxcrt/cfx_retain_ptr.h
index bff1b9691cd2d15913ee318df3310366e87efafe..1b137d4974fb71317ad05e0e750f5b11d4f53a40 100644
--- a/core/fxcrt/cfx_retain_ptr.h
+++ b/core/fxcrt/cfx_retain_ptr.h
@@ -37,6 +37,10 @@ class CFX_RetainPtr {
   T* Get() const { return m_pObj.get(); }
   void Swap(CFX_RetainPtr& that) { m_pObj.swap(that.m_pObj); }
 
+  // TODO(tsepez): temporary scaffolding, to be removed.
+  T* Leak() { return m_pObj.release(); }
+  void Unleak(T* ptr) { m_pObj.reset(ptr); }

[Wei Li, 2016/12/28 19:35:04]

I don't quite understand the needs for these functions. Maybe we shouldn't use
CFX_RetainPtr if we need these functions?

+
   CFX_RetainPtr& operator=(const CFX_RetainPtr& that) {
     if (*this != that)
       Reset(that.Get());