Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2583063003: Improve documentation of ObjectPaintProperties (Closed)

Created:
4 years ago by pdr.
Modified:
4 years ago
Reviewers:
Xianzhu, trchen, wkorman
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve documentation of ObjectPaintProperties This patch adds a new class-level comment to ObjectPaintProperties. A long implementation note about the clear and update functions has also been added, and the existing copy pasta comments have been removed. BUG=645667 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/72f6a832d5b791d8a15b3ee9b722cfa2ea3dd589 Cr-Commit-Position: refs/heads/master@{#439616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -37 lines) Patch
M third_party/WebKit/Source/core/paint/ObjectPaintProperties.h View 7 chunks +41 lines, -37 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
pdr.
4 years ago (2016-12-19 19:39:33 UTC) #3
wkorman
lgtm
4 years ago (2016-12-19 19:49:49 UTC) #4
trchen
lgtm
4 years ago (2016-12-19 20:52:53 UTC) #5
pdr.
Chris had some comments in my other cl about putting these comments in README.md, but ...
4 years ago (2016-12-19 21:42:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583063003/1
4 years ago (2016-12-19 21:42:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 23:44:40 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-19 23:46:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72f6a832d5b791d8a15b3ee9b722cfa2ea3dd589
Cr-Commit-Position: refs/heads/master@{#439616}

Powered by Google App Engine
This is Rietveld 408576698