Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2583053003:
Improve saturated_cast performance (Closed)
DescriptionImprove saturated_cast performance
Plumb custom bounds through DstRangeRelationToSrcRange to remove
duplicate comparisons. Refactor RangeConstraint from an enum to a class
containing bools, which can be independently evaluated at compile-time.
Re-land minus ODR conflict: https://codereview.chromium.org/2585043002/
TBR=tsepez
Committed: https://crrev.com/e3bd1f6de34f95d131264c9a79282fb9b47a5242
Cr-Commit-Position: refs/heads/master@{#439714}
Patch Set 1 #Patch Set 2 : nit #
Messages
Total messages: 24 (15 generated)
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
jschuh@chromium.org changed reviewers: + tsepez@chromium.org
ptal - I made the old names work to avoid whatever ODR conflicts we're hitting.
The CQ bit was checked by jschuh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Improve saturated_cast performance Plumb custom bounds through DstRangeRelationToSrcRange to remove duplicate comparisons. Refactor RangeConstraint from an enum to a class containing bools, which can be independently evaluated at compile-time. Re-land minus ODR conflict: https://codereview.chromium.org/2585043002/ ========== to ========== Improve saturated_cast performance Plumb custom bounds through DstRangeRelationToSrcRange to remove duplicate comparisons. Refactor RangeConstraint from an enum to a class containing bools, which can be independently evaluated at compile-time. Re-land minus ODR conflict: https://codereview.chromium.org/2585043002/ TBR=tsepez ==========
The CQ bit was unchecked by jschuh@chromium.org
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482199433989120,
"parent_rev": "4661f04939d2b4a0e90043ec1901a55b4b91fb49", "commit_rev":
"2b26eb71a59ea4cccf2be5876ae74b27a7e3c6e3"}
Message was sent while issue was closed.
Description was changed from ========== Improve saturated_cast performance Plumb custom bounds through DstRangeRelationToSrcRange to remove duplicate comparisons. Refactor RangeConstraint from an enum to a class containing bools, which can be independently evaluated at compile-time. Re-land minus ODR conflict: https://codereview.chromium.org/2585043002/ TBR=tsepez ========== to ========== Improve saturated_cast performance Plumb custom bounds through DstRangeRelationToSrcRange to remove duplicate comparisons. Refactor RangeConstraint from an enum to a class containing bools, which can be independently evaluated at compile-time. Re-land minus ODR conflict: https://codereview.chromium.org/2585043002/ TBR=tsepez Review-Url: https://codereview.chromium.org/2583053003 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Improve saturated_cast performance Plumb custom bounds through DstRangeRelationToSrcRange to remove duplicate comparisons. Refactor RangeConstraint from an enum to a class containing bools, which can be independently evaluated at compile-time. Re-land minus ODR conflict: https://codereview.chromium.org/2585043002/ TBR=tsepez Review-Url: https://codereview.chromium.org/2583053003 ========== to ========== Improve saturated_cast performance Plumb custom bounds through DstRangeRelationToSrcRange to remove duplicate comparisons. Refactor RangeConstraint from an enum to a class containing bools, which can be independently evaluated at compile-time. Re-land minus ODR conflict: https://codereview.chromium.org/2585043002/ TBR=tsepez Committed: https://crrev.com/e3bd1f6de34f95d131264c9a79282fb9b47a5242 Cr-Commit-Position: refs/heads/master@{#439714} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e3bd1f6de34f95d131264c9a79282fb9b47a5242 Cr-Commit-Position: refs/heads/master@{#439714} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
