Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2583043002: parser: Invalid xml version on prolog shouldn't crash (Closed)

Created:
4 years ago by kouhei (in TOK)
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, dominicc+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

parser: Invalid xml version on prolog shouldn't crash BUG=628016 Committed: https://crrev.com/fdf397d40c16b0bc3f926d06faa093439b5f8ae3 Cr-Commit-Position: refs/heads/master@{#439402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/parser/invalid-xml-ver.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kouhei (in TOK)
4 years ago (2016-12-19 02:10:45 UTC) #2
haraken
LGTM
4 years ago (2016-12-19 02:12:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583043002/1
4 years ago (2016-12-19 02:12:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 04:02:57 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-19 04:05:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdf397d40c16b0bc3f926d06faa093439b5f8ae3
Cr-Commit-Position: refs/heads/master@{#439402}

Powered by Google App Engine
This is Rietveld 408576698