Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2583033003: [heap] Use RAIL mode for starting incremental marking. (Closed)

Created:
4 years ago by ulan
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use RAIL mode for starting incremental marking. This patch delays start of incremental marking during L phase of RAIL and adjusts ShouldOptimizeForLoadTime to check allocation limit. BUG=chromium:613518 Review-Url: https://codereview.chromium.org/2583033003 Cr-Commit-Position: refs/heads/master@{#41797} Committed: https://chromium.googlesource.com/v8/v8/+/039e29f7505cf75d27d7681fab51d50f53dcc7bd

Patch Set 1 #

Patch Set 2 : adjust constant #

Patch Set 3 : adjust constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M src/heap/heap.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
ulan
PTAL. I missed this part while relanding 7bdb90.
4 years ago (2016-12-19 08:48:16 UTC) #2
Michael Lippautz
On 2016/12/19 08:48:16, ulan wrote: > PTAL. I missed this part while relanding 7bdb90. lgtm
4 years ago (2016-12-19 09:23:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583033003/40001
4 years ago (2016-12-19 10:41:36 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-19 11:34:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/039e29f7505cf75d27d7681fab51d50f53d...

Powered by Google App Engine
This is Rietveld 408576698