LogDog: Re-use Pub/Sub gRPC clients.

LogDog: Re-use Pub/Sub gRPC clients.

Since a single Tumble mutation may perform multiple Pub/Sub publishes,
re-use a single Pub/Sub gRPC client. Clients are bound to the projects
that they are created from, and free'd at the end of the handler's
operation via a service-wide close.

Leave the archival publisher Close in (even though it's no-op) since
it's a useful check on archival publisher lifecycle.

BUG=chromium:675401
TEST=None
R=vadimsh@chromium.org

Review-Url: https://codereview.chromium.org/2583033002
Committed: https://github.com/luci/luci-go/commit/fad4dadaa7d4d99fc00958a4d5281af7f9d85a7c

[dnj, 2016-12-18 22:53:02]

PTAL

[Vadim Sh., 2016-12-19 19:59:45]

lgtm with optional nit

https://codereview.chromium.org/2583033002/diff/1/logdog/appengine/coordinato...
File logdog/appengine/coordinator/service.go (right):

https://codereview.chromium.org/2583033002/diff/1/logdog/appengine/coordinato...
logdog/appengine/coordinator/service.go:130: for proj, client := range
s.pubSubClients {
nit: do it under the mutex for consistency.

[dnj, 2016-12-19 21:43:55]

https://codereview.chromium.org/2583033002/diff/1/logdog/appengine/coordinato...
File logdog/appengine/coordinator/service.go (right):

https://codereview.chromium.org/2583033002/diff/1/logdog/appengine/coordinato...
logdog/appengine/coordinator/service.go:130: for proj, client := range
s.pubSubClients {
On 2016/12/19 19:59:45, Vadim Sh. wrote:
> nit: do it under the mutex for consistency.

Done.

[dnj, 2016-12-19 21:44:10]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-12-19 21:44:10]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2583033002/#ps20001
(title: "close under lock")

[commit-bot: I haz the power, 2016-12-19 21:44:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 21:50:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482183850487990,
"parent_rev": "3f27478caedc4593adf1ebc8f4ad71189eb325b9", "commit_rev":
"fad4dadaa7d4d99fc00958a4d5281af7f9d85a7c"}

[commit-bot: I haz the power, 2016-12-19 21:50:34]

Description was changed from

==========
LogDog: Re-use Pub/Sub gRPC clients.

Since a single Tumble mutation may perform multiple Pub/Sub publishes,
re-use a single Pub/Sub gRPC client. Clients are bound to the projects
that they are created from, and free'd at the end of the handler's
operation via a service-wide close.

Leave the archival publisher Close in (even though it's no-op) since
it's a useful check on archival publisher lifecycle.

BUG=chromium:675401
TEST=None
R=vadimsh@chromium.org
==========

to

==========
LogDog: Re-use Pub/Sub gRPC clients.

Since a single Tumble mutation may perform multiple Pub/Sub publishes,
re-use a single Pub/Sub gRPC client. Clients are bound to the projects
that they are created from, and free'd at the end of the handler's
operation via a service-wide close.

Leave the archival publisher Close in (even though it's no-op) since
it's a useful check on archival publisher lifecycle.

BUG=chromium:675401
TEST=None
R=vadimsh@chromium.org

Review-Url: https://codereview.chromium.org/2583033002
Committed:
https://github.com/luci/luci-go/commit/fad4dadaa7d4d99fc00958a4d5281af7f9d85a7c
==========

[commit-bot: I haz the power, 2016-12-19 21:50:35]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/fad4dadaa7d4d99fc00958a4d5281af7f9d85a7c