[intl] Add new semantics + compat fallback to Intl constructor

[intl] Add new semantics + compat fallback to Intl constructor

ECMA 402 v2 made Intl constructors more strict in terms of how they would
initialize objects, refusing to initialize objects which have already
been constructed. However, when Chrome tried to ship these semantics,
we ran into web compatibility issues.

This patch tries to square the circle and implement the simpler v2 object
semantics while including a compatibility workaround to allow objects to
sort of be initialized later, storing the real underlying Intl object
in a symbol-named property.

The new semantics are described in this PR against the ECMA 402 spec:
https://github.com/tc39/ecma402/pull/84

BUG=v8:4360, v8:4870
LOG=Y

Review-Url: https://codereview.chromium.org/2582993002
Cr-Commit-Position: refs/heads/master@{#41943}
Committed: https://chromium.googlesource.com/v8/v8/+/b0a09d78095b49ce7d3551032a65f707456c1f27

[Dan Ehrenberg, 2016-12-18 08:10:33]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-18 08:10:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-18 08:27:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-18 08:27:25]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Dan Ehrenberg, 2016-12-18 09:20:16]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-18 09:20:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-12-18 09:21:53]

Description was changed from

==========
[intl] Add new semantics + compat fallback to Intl constructor

ECMA 402 v2 made Intl constructors more strict in terms of how they would
initialize objects, refusing to initialize objects which have already
been constructed. However, when Chrome tried to ship these semantics,
we ran into web compatibility issues.

This patch tries to square the circle and implement the simpler v2 object
semantics while including a compatibility workaround to allow objects to
sort of be initialized later, storing the real underlying Intl object
in a symbol-named property.

BUG=v8:4360, v8:4870
LOG=Y
R=adamk
==========

to

==========
[intl] Add new semantics + compat fallback to Intl constructor

ECMA 402 v2 made Intl constructors more strict in terms of how they would
initialize objects, refusing to initialize objects which have already
been constructed. However, when Chrome tried to ship these semantics,
we ran into web compatibility issues.

This patch tries to square the circle and implement the simpler v2 object
semantics while including a compatibility workaround to allow objects to
sort of be initialized later, storing the real underlying Intl object
in a symbol-named property.

BUG=v8:4360, v8:4870
LOG=Y
==========

[Dan Ehrenberg, 2016-12-18 09:21:53]

littledan@chromium.org changed reviewers:
+ petermarshall@chromium.org
- adamk@chromium.org

[commit-bot: I haz the power, 2016-12-18 09:37:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-18 09:37:29]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14424)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Dan Ehrenberg, 2016-12-18 10:25:42]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-18 10:25:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-18 10:43:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-18 10:43:47]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-12-20 15:47:37]

Description was changed from

==========
[intl] Add new semantics + compat fallback to Intl constructor

ECMA 402 v2 made Intl constructors more strict in terms of how they would
initialize objects, refusing to initialize objects which have already
been constructed. However, when Chrome tried to ship these semantics,
we ran into web compatibility issues.

This patch tries to square the circle and implement the simpler v2 object
semantics while including a compatibility workaround to allow objects to
sort of be initialized later, storing the real underlying Intl object
in a symbol-named property.

BUG=v8:4360, v8:4870
LOG=Y
==========

to

==========
[intl] Add new semantics + compat fallback to Intl constructor

ECMA 402 v2 made Intl constructors more strict in terms of how they would
initialize objects, refusing to initialize objects which have already
been constructed. However, when Chrome tried to ship these semantics,
we ran into web compatibility issues.

This patch tries to square the circle and implement the simpler v2 object
semantics while including a compatibility workaround to allow objects to
sort of be initialized later, storing the real underlying Intl object
in a symbol-named property.

The new semantics are described in this PR against the ECMA 402 spec:
https://github.com/tc39/ecma402/pull/84

BUG=v8:4360, v8:4870
LOG=Y
==========

[Dan Ehrenberg, 2016-12-20 15:56:02]

littledan@chromium.org changed reviewers:
+ yangguo@chromium.org
- petermarshall@chromium.org

[Dan Ehrenberg, 2016-12-20 15:59:10]

Yang, do you think you could take a look? Previously this was addressed to
Peter, but sounds like you'd be the best reviewer at the moment.

[Dan Ehrenberg, 2016-12-20 23:12:39]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 23:12:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 23:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 23:48:16]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-12-23 09:05:46]

lgtm

https://codereview.chromium.org/2582993002/diff/60001/src/js/i18n.js
File src/js/i18n.js (right):

https://codereview.chromium.org/2582993002/diff/60001/src/js/i18n.js#newcode61
src/js/i18n.js:61: function AddBoundMethod(obj, methodName, implementation,
length, typename, compat) {
80 char limit

https://codereview.chromium.org/2582993002/diff/60001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-4870.js (right):

https://codereview.chromium.org/2582993002/diff/60001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-4870.js:4: 
80 char limit

[Dan Ehrenberg, 2016-12-23 14:01:53]

https://codereview.chromium.org/2582993002/diff/60001/src/js/i18n.js
File src/js/i18n.js (right):

https://codereview.chromium.org/2582993002/diff/60001/src/js/i18n.js#newcode61
src/js/i18n.js:61: function AddBoundMethod(obj, methodName, implementation,
length, typename, compat) {
On 2016/12/23 09:05:46, Yang wrote:
> 80 char limit

Done.

https://codereview.chromium.org/2582993002/diff/60001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-4870.js (right):

https://codereview.chromium.org/2582993002/diff/60001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-4870.js:4: 
On 2016/12/23 09:05:46, Yang wrote:
> 80 char limit

Done.

[Dan Ehrenberg, 2016-12-23 14:01:59]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-12-23 14:01:59]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2582993002/#ps80001
(title: "reformatting")

[commit-bot: I haz the power, 2016-12-23 14:02:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 14:32:17]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482501719393840,
"parent_rev": "e92118bbc25c39b3213a3f4dcbf35e825eaf0b8a", "commit_rev":
"b0a09d78095b49ce7d3551032a65f707456c1f27"}

[commit-bot: I haz the power, 2016-12-23 14:32:21]

Description was changed from

==========
[intl] Add new semantics + compat fallback to Intl constructor

ECMA 402 v2 made Intl constructors more strict in terms of how they would
initialize objects, refusing to initialize objects which have already
been constructed. However, when Chrome tried to ship these semantics,
we ran into web compatibility issues.

This patch tries to square the circle and implement the simpler v2 object
semantics while including a compatibility workaround to allow objects to
sort of be initialized later, storing the real underlying Intl object
in a symbol-named property.

The new semantics are described in this PR against the ECMA 402 spec:
https://github.com/tc39/ecma402/pull/84

BUG=v8:4360, v8:4870
LOG=Y
==========

to

==========
[intl] Add new semantics + compat fallback to Intl constructor

ECMA 402 v2 made Intl constructors more strict in terms of how they would
initialize objects, refusing to initialize objects which have already
been constructed. However, when Chrome tried to ship these semantics,
we ran into web compatibility issues.

This patch tries to square the circle and implement the simpler v2 object
semantics while including a compatibility workaround to allow objects to
sort of be initialized later, storing the real underlying Intl object
in a symbol-named property.

The new semantics are described in this PR against the ECMA 402 spec:
https://github.com/tc39/ecma402/pull/84

BUG=v8:4360, v8:4870
LOG=Y

Review-Url: https://codereview.chromium.org/2582993002
Cr-Commit-Position: refs/heads/master@{#41943}
Committed:
https://chromium.googlesource.com/v8/v8/+/b0a09d78095b49ce7d3551032a65f707456...
==========

[commit-bot: I haz the power, 2016-12-23 14:32:22]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/b0a09d78095b49ce7d3551032a65f707456...