Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2582973002:
S390: Use TM instead of TMLL in case of memory operand. (Closed)
DescriptionUse TM instead of TMLL in case of memory operand.
R=jyan@ca.ibm.com, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
Review-Url: https://codereview.chromium.org/2582973002
Cr-Commit-Position: refs/heads/master@{#41824}
Committed: https://chromium.googlesource.com/v8/v8/+/8c6ace9884440c983b86804cde6a7ef8c3e1b4fe
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix to Joran's comment #
Messages
Total messages: 29 (21 generated)
Description was changed from ========== Use TM instead of TMLL in case of memory operand. BUG= ========== to ========== Use TM instead of TMLL in case of memory operand. BUG= ==========
Description was changed from ========== Use TM instead of TMLL in case of memory operand. BUG= ========== to ========== Use TM instead of TMLL in case of memory operand. BUG= ==========
sampsong@ca.ibm.com changed reviewers: + bjaideep@ca.ibm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
sampsong@ca.ibm.com changed reviewers: + bjaideep@ca.ibm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
Description was changed from ========== Use TM instead of TMLL in case of memory operand. BUG= ========== to ========== Use TM instead of TMLL in case of memory operand. R=jyan@ca.ibm.com, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com BUG= ==========
Please take a look. Thanks!
https://codereview.chromium.org/2582973002/diff/1/src/s390/macro-assembler-s3... File src/s390/macro-assembler-s390.h (right): https://codereview.chromium.org/2582973002/diff/1/src/s390/macro-assembler-s3... src/s390/macro-assembler-s390.h:1561: UNIMPLEMENTED(); A bit concerned about this unimplemented path... as it'll likely be a matter of time before we hit this. :|
lgtm
The CQ bit was checked by sampsong@ca.ibm.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sampsong@ca.ibm.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482179428026240,
"parent_rev": "35bf403f0db3c053374f7cef20d1202227e7916d", "commit_rev":
"8c6ace9884440c983b86804cde6a7ef8c3e1b4fe"}
Message was sent while issue was closed.
Description was changed from ========== Use TM instead of TMLL in case of memory operand. R=jyan@ca.ibm.com, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com BUG= ========== to ========== Use TM instead of TMLL in case of memory operand. R=jyan@ca.ibm.com, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2582973002 Cr-Commit-Position: refs/heads/master@{#41824} Committed: https://chromium.googlesource.com/v8/v8/+/8c6ace9884440c983b86804cde6a7ef8c3e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/8c6ace9884440c983b86804cde6a7ef8c3e...
Message was sent while issue was closed.
Description was changed from ========== Use TM instead of TMLL in case of memory operand. R=jyan@ca.ibm.com, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2582973002 Cr-Commit-Position: refs/heads/master@{#41824} Committed: https://chromium.googlesource.com/v8/v8/+/8c6ace9884440c983b86804cde6a7ef8c3e... ========== to ========== Use TM instead of TMLL in case of memory operand. R=jyan@ca.ibm.com, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2582973002 Cr-Commit-Position: refs/heads/master@{#41824} Committed: https://chromium.googlesource.com/v8/v8/+/8c6ace9884440c983b86804cde6a7ef8c3e... ==========
The CQ bit was checked by sampsong@ca.ibm.com
The patchset sent to the CQ was uploaded after l-g-t-m from jyan@ca.ibm.com Link to the patchset: https://codereview.chromium.org/2582973002/#ps40001 (title: "Change to LoadP to LoadB")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14513)
The CQ bit was checked by sampsong@ca.ibm.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...) v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/18111) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/18171) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/18077) v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30998) v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...) v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/19815)
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2586253003/ by sampsong@ca.ibm.com. The reason for reverting is: Not passing cq run after minor fix.
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
