Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2582913002:
Remove obsolete NGConstraintSpace::ChildSpace (Closed)
|
Created:
4 years ago by Gleb Lanbin Modified:
4 years ago CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove obsolete NGConstraintSpace::ChildSpace
After http://crrev.com/2562703003 NGConstraintSpace::ChildSpace became obsolete. Therefore this patch removes it.
BUG=635619
Committed: https://crrev.com/c3d0d04110e4a51acf4749507a42df8d18fc3022
Cr-Commit-Position: refs/heads/master@{#439354}
Patch Set 1 #
Messages
Total messages: 22 (17 generated)
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
glebl@chromium.org changed reviewers: + ikilpatrick@chromium.org
lgtm
The CQ bit was checked by cbiesinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482011179997570, "parent_rev":
"221ee9721d515c13ee3d14ca793c20ab2b099862", "commit_rev":
"581d84672380c75024a0f5b300252766cd0290cd"}
Message was sent while issue was closed.
Description was changed from ========== Remove obsolete NGConstraintSpace::ChildSpace After http://crrev.com/2562703003 NGConstraintSpace::ChildSpace became obsolete. Therefore this patch removes it. BUG=635619 ========== to ========== Remove obsolete NGConstraintSpace::ChildSpace After http://crrev.com/2562703003 NGConstraintSpace::ChildSpace became obsolete. Therefore this patch removes it. BUG=635619 Review-Url: https://codereview.chromium.org/2582913002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove obsolete NGConstraintSpace::ChildSpace After http://crrev.com/2562703003 NGConstraintSpace::ChildSpace became obsolete. Therefore this patch removes it. BUG=635619 Review-Url: https://codereview.chromium.org/2582913002 ========== to ========== Remove obsolete NGConstraintSpace::ChildSpace After http://crrev.com/2562703003 NGConstraintSpace::ChildSpace became obsolete. Therefore this patch removes it. BUG=635619 Committed: https://crrev.com/c3d0d04110e4a51acf4749507a42df8d18fc3022 Cr-Commit-Position: refs/heads/master@{#439354} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c3d0d04110e4a51acf4749507a42df8d18fc3022 Cr-Commit-Position: refs/heads/master@{#439354} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
