[ios] Added deprecation comments and TODOs for ios/web classes/protocols

[ios] Added deprecation comments and TODOs for ios/web classes/protocols

The following classes/protocols are deprecated:
 - CRWSessionController
 - CRWSessionEntry
 - CRWWebDelegate
 - CRWWebUserInterfaceDelegate
 - CRWWebControllerObserver

BUG=616244
Committed: https://crrev.com/0f9dd59471dcf2b1e6968b861168897d4a0d4695
Cr-Commit-Position: refs/heads/master@{#439208}

[Eugene But (OOO till 7-30), 2016-12-16 19:07:04]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[kkhorimoto, 2016-12-16 19:25:52]

This looks good, but can we switch to using the DEPRECATED_MSG_ATTRIBUTE() macro
so we actually get compiler warnings when deprecated classes are used?

[kkhorimoto, 2016-12-16 19:27:44]

On 2016/12/16 19:25:52, kkhorimoto_ wrote:
> This looks good, but can we switch to using the DEPRECATED_MSG_ATTRIBUTE()
macro
> so we actually get compiler warnings when deprecated classes are used?

That would also entail adding -Wno-error=deprecated-declarations to the web
target.

[Eugene But (OOO till 7-30), 2016-12-16 19:37:38]

On 2016/12/16 19:27:44, kkhorimoto_ wrote:
> On 2016/12/16 19:25:52, kkhorimoto_ wrote:
> > This looks good, but can we switch to using the DEPRECATED_MSG_ATTRIBUTE()
> macro
> > so we actually get compiler warnings when deprecated classes are used?
> 
> That would also entail adding -Wno-error=deprecated-declarations to the web
> target.
This is a good suggestion, but I would rather not to add
-Wno-error=deprecated-declarations to web because it will silence useful
warnings. 
Also using DEPRECATED_MSG_ATTRIBUTE will create bunch of warnings during the
compilation, which we won't be able to fix in the reasonable timeframe. So I
think this will bring more harm than value. WDYT?

[kkhorimoto, 2016-12-16 21:07:20]

On 2016/12/16 19:37:38, Eugene But wrote:
> On 2016/12/16 19:27:44, kkhorimoto_ wrote:
> > On 2016/12/16 19:25:52, kkhorimoto_ wrote:
> > > This looks good, but can we switch to using the DEPRECATED_MSG_ATTRIBUTE()
> > macro
> > > so we actually get compiler warnings when deprecated classes are used?
> > 
> > That would also entail adding -Wno-error=deprecated-declarations to the web
> > target.
> This is a good suggestion, but I would rather not to add
> -Wno-error=deprecated-declarations to web because it will silence useful
> warnings. 
> Also using DEPRECATED_MSG_ATTRIBUTE will create bunch of warnings during the
> compilation, which we won't be able to fix in the reasonable timeframe. So I
> think this will bring more harm than value. WDYT?

Hmm, yeah you're right; we already have enough deprecation warnings that we need
to ignore from third_party and piper classes.  Maybe after I finish eliminating
the CRWSessionController/CRWSessionEntry, we'll have few enough uses of these
classes to warrant the deprecation warning.  lgtm

[Eugene But (OOO till 7-30), 2016-12-16 21:54:59]

Thanks!

[Eugene But (OOO till 7-30), 2016-12-16 21:55:03]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-12-16 21:55:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 22:09:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481925303471660, "parent_rev":
"60b0491a78d96c8ac5fa77bda8fd39792727b12d", "commit_rev":
"0d03ad6eabf782fa71f2932adf66a670e736ef05"}

[commit-bot: I haz the power, 2016-12-16 22:09:42]

Description was changed from

==========
[ios] Added deprecation comments and TODOs for ios/web classes/protocols

The following classes/protocols are deprecated:
 - CRWSessionController
 - CRWSessionEntry
 - CRWWebDelegate
 - CRWWebUserInterfaceDelegate
 - CRWWebControllerObserver

BUG=616244
==========

to

==========
[ios] Added deprecation comments and TODOs for ios/web classes/protocols

The following classes/protocols are deprecated:
 - CRWSessionController
 - CRWSessionEntry
 - CRWWebDelegate
 - CRWWebUserInterfaceDelegate
 - CRWWebControllerObserver

BUG=616244

Review-Url: https://codereview.chromium.org/2582843002
==========

[commit-bot: I haz the power, 2016-12-16 22:09:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-16 22:11:36]

Description was changed from

==========
[ios] Added deprecation comments and TODOs for ios/web classes/protocols

The following classes/protocols are deprecated:
 - CRWSessionController
 - CRWSessionEntry
 - CRWWebDelegate
 - CRWWebUserInterfaceDelegate
 - CRWWebControllerObserver

BUG=616244

Review-Url: https://codereview.chromium.org/2582843002
==========

to

==========
[ios] Added deprecation comments and TODOs for ios/web classes/protocols

The following classes/protocols are deprecated:
 - CRWSessionController
 - CRWSessionEntry
 - CRWWebDelegate
 - CRWWebUserInterfaceDelegate
 - CRWWebControllerObserver

BUG=616244

Committed: https://crrev.com/0f9dd59471dcf2b1e6968b861168897d4a0d4695
Cr-Commit-Position: refs/heads/master@{#439208}
==========

[commit-bot: I haz the power, 2016-12-16 22:11:37]

Patchset 1 (id:??) landed as
https://crrev.com/0f9dd59471dcf2b1e6968b861168897d4a0d4695
Cr-Commit-Position: refs/heads/master@{#439208}