📰 Make NewTabPageAdapterTest failures more explicit

[NTP Client] Make NewTabPageAdapterTest failures more explicit

BUG=

Committed: https://crrev.com/aabf81e3c827e49ac8094a91c19dc4b9cd030be2
Cr-Commit-Position: refs/heads/master@{#439183}

[dgn, 2016-12-16 12:35:52]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 12:36:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2016-12-16 12:36:36]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org

[dgn, 2016-12-16 12:36:36]

PTAL. Changes extracted from https://codereview.chromium.org/2573173002

[commit-bot: I haz the power, 2016-12-16 13:34:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 13:34:55]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-12-16 17:14:44]

https://codereview.chromium.org/2582793002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
(right):

https://codereview.chromium.org/2582793002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:951:
private static void explainFailedExpectation(
Could you make this return a string that you can pass in to fail()? Then you
don't have to do all this business with ShadowLog; just append to a
StringBuilder.

[dgn, 2016-12-16 19:23:59]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[dgn, 2016-12-16 19:24:11]

PTAL. Sample output:

java.lang.AssertionError: Type mismatch at position 6
explainFailedExpectation -- START -- 
0 - ABOVE_THE_FOLD
1 - HEADER
2 - SNIPPET
3 - SNIPPET
4 - SNIPPET
5 - SNIPPET
6 - FOOTER <= expected: SNIPPET
7 - SPACING
explainFailedExpectation -- END --

https://codereview.chromium.org/2582793002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
(right):

https://codereview.chromium.org/2582793002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:951:
private static void explainFailedExpectation(
On 2016/12/16 17:14:44, Bernhard Bauer wrote:
> Could you make this return a string that you can pass in to fail()? Then you
> don't have to do all this business with ShadowLog; just append to a
> StringBuilder.

True... I guess since it's not an android log I don't need to have each log line
prefixed. Done.

[commit-bot: I haz the power, 2016-12-16 19:24:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-12-16 19:37:27]

lgtm

[dgn, 2016-12-16 20:00:18]

The CQ bit was unchecked by dgn@chromium.org

[dgn, 2016-12-16 20:00:18]

The CQ bit was checked by dgn@chromium.org

[commit-bot: I haz the power, 2016-12-16 20:00:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 20:53:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481918418796110,
"parent_rev": "170d96484d5b979ded630872d3c5a28429165cae", "commit_rev":
"69365949d9ed5f7150ebfa078aebd98eaeb7bc39"}

[commit-bot: I haz the power, 2016-12-16 20:54:00]

Description was changed from

==========
[NTP Client] Make NewTabPageAdapterTest failures more explicit

BUG=
==========

to

==========
[NTP Client] Make NewTabPageAdapterTest failures more explicit

BUG=

Review-Url: https://codereview.chromium.org/2582793002
==========

[commit-bot: I haz the power, 2016-12-16 20:54:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-16 20:57:17]

Description was changed from

==========
[NTP Client] Make NewTabPageAdapterTest failures more explicit

BUG=

Review-Url: https://codereview.chromium.org/2582793002
==========

to

==========
[NTP Client] Make NewTabPageAdapterTest failures more explicit

BUG=

Committed: https://crrev.com/aabf81e3c827e49ac8094a91c19dc4b9cd030be2
Cr-Commit-Position: refs/heads/master@{#439183}
==========

[commit-bot: I haz the power, 2016-12-16 20:57:18]

Patchset 2 (id:??) landed as
https://crrev.com/aabf81e3c827e49ac8094a91c19dc4b9cd030be2
Cr-Commit-Position: refs/heads/master@{#439183}