Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2582723002: ImageCapture v4l2: retry reading capabilities (Closed)

Created:
4 years ago by mcasas
Modified:
4 years ago
Reviewers:
emircan
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ImageCapture v4l2: retry reading capabilities The bug illustrates a case in which an ioctl() for reading the photo capabilities right after opening the device/starting streaming fails, but work after retrying a few times. (In my repros, the first two control readings fail, successively working). This CL reuses the code in ResetUserAndCameraControlsToDefault() to retry an ioclt a few times for RetrieveUserControlRange(). BUG=670262 Committed: https://crrev.com/047c7091b7159c5ad0037d0e35d74e1e4739e080 Cr-Commit-Position: refs/heads/master@{#439223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M media/capture/video/linux/v4l2_capture_delegate.cc View 3 chunks +20 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mcasas
emircan@ PTAL No templates this time :-)
4 years ago (2016-12-16 03:30:36 UTC) #2
emircan
lgtm
4 years ago (2016-12-16 19:20:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582723002/1
4 years ago (2016-12-16 22:43:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 22:49:12 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-16 22:50:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/047c7091b7159c5ad0037d0e35d74e1e4739e080
Cr-Commit-Position: refs/heads/master@{#439223}

Powered by Google App Engine
This is Rietveld 408576698