[USS] Impelementation for GetData and GetAllData

components/autofill/core/browser/webdata/autocomplete_sync_bridge.h

Index: components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
diff --git a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
index 2a575ed9c500f213ce8c329f1b027c75c18a2bd2..9ee2103b45086fa9e1df8c2f3e0fa47f84dbaa95 100644
--- a/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
+++ b/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
@@ -65,9 +65,23 @@ class AutocompleteSyncBridge : public base::SupportsUserData::Data,
   void AutofillEntriesChanged(const AutofillChangeList& changes) override;
 
  private:
+  friend class AutocompleteSyncBridgeTest;
+
   // Returns the table associated with the |web_data_backend_|.
   AutofillTable* GetAutofillTable() const;
 
+  const std::string GetStorageKeyFromAutofillEntry(

[skym, 2016/12/19 17:40:08]

Why are all these functions returning const strings? I don't see what value the
const is adding.

[Gang Wu, 2016/12/19 23:28:09]

Done.

+      const autofill::AutofillEntry& entry);
+
+  static const std::string FormatStorageKey(const std::string& name,
+                                            const std::string& value);
+
+  static std::unique_ptr<syncer::EntityData> CreateEntityData(
+      const AutofillEntry& entry);
+
+  static AutofillEntry CreateAutofillEntry(
+      const sync_pb::AutofillSpecifics* autofill_specifics);

[skym, 2016/12/19 17:40:08]

Why not take a const sync_pb::AutofillSpecifics&

[Gang Wu, 2016/12/19 23:28:09]

Done.

+
   base::ThreadChecker thread_checker_;
 
   // AutocompleteSyncBridge is owned by |web_data_backend_| through