[USS] Impelementation for GetData and GetAllData

components/autofill/core/browser/webdata/autocomplete_sync_bridge.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOCOMPLETE_SYNC_BRIDGE_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOCOMPLETE_SYNC_BRIDGE_H_
 
 #include "base/scoped_observer.h"
 #include "base/supports_user_data.h"
 #include "base/threading/non_thread_safe.h"
@@ skipping 47 matching lines @@
   std::string GetClientTag(const syncer::EntityData& entity_data) override;
   // Generate a string key uniquely identifying |entity_data| in the context of
   // local storage. The format, which should stay the same, is $name|$value"
   // where $name and $value are escaped.
   std::string GetStorageKey(const syncer::EntityData& entity_data) override;
 
   // AutofillWebDataServiceObserverOnDBThread implementation.
   void AutofillEntriesChanged(const AutofillChangeList& changes) override;
 
  private:
+  friend class AutocompleteSyncBridgeTest;
+
   // Returns the table associated with the |web_data_backend_|.
   AutofillTable* GetAutofillTable() const;
 
+  const std::string GetStorageKeyFromAutofillEntry(

[skym, 2016/12/19 17:40:08]

Why are all these functions returning const strings? I don't see what value the
const is adding.

[Gang Wu, 2016/12/19 23:28:09]

Done.

+      const autofill::AutofillEntry& entry);
+
+  static const std::string FormatStorageKey(const std::string& name,
+                                            const std::string& value);
+
+  static std::unique_ptr<syncer::EntityData> CreateEntityData(
+      const AutofillEntry& entry);
+
+  static AutofillEntry CreateAutofillEntry(
+      const sync_pb::AutofillSpecifics* autofill_specifics);

[skym, 2016/12/19 17:40:08]

Why not take a const sync_pb::AutofillSpecifics&

[Gang Wu, 2016/12/19 23:28:09]

Done.

+
   base::ThreadChecker thread_checker_;
 
   // AutocompleteSyncBridge is owned by |web_data_backend_| through
   // SupportsUserData, so it's guaranteed to outlive |this|.
   AutofillWebDataBackend* const web_data_backend_;
 
   ScopedObserver<AutofillWebDataBackend, AutocompleteSyncBridge>
       scoped_observer_;
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOCOMPLETE_SYNC_BRIDGE_H_