Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: media/audio/audio_manager_base.h

Issue 2582703003: Audio output debug recording. (Closed)
Patch Set: Changed to record in AudioOutputResampler. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_manager_base.h
diff --git a/media/audio/audio_manager_base.h b/media/audio/audio_manager_base.h
index b3100cf6c507bb6cb6af2086806356cc3c6de15a..52620dfe3cb67fe7c7e17862f5467dad32dabe68 100644
--- a/media/audio/audio_manager_base.h
+++ b/media/audio/audio_manager_base.h
@@ -11,6 +11,7 @@
#include <utility>
#include "base/compiler_specific.h"
+#include "base/files/file_path.h"
#include "base/macros.h"
#include "base/memory/scoped_vector.h"
#include "base/observer_list.h"
@@ -27,6 +28,7 @@
namespace media {
class AudioOutputDispatcher;
+class AudioOutputResampler;
// AudioManagerBase provides AudioManager functions common for all platforms.
class MEDIA_EXPORT AudioManagerBase : public AudioManager {
@@ -67,6 +69,11 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager {
const std::string& input_device_id) override;
std::unique_ptr<AudioLog> CreateAudioLog(
AudioLogFactory::AudioComponent component) override;
+ std::unique_ptr<AudioFileWriter> CreateAudioFileWriter(
+ const AudioParameters& params) override;
+ void EnableOutputDebugRecording(
+ const base::FilePath& base_file_name) override;
+ void DisableOutputDebugRecording() override;
void SetMaxStreamCountForTesting(int max_input, int max_output) final;
@@ -111,7 +118,8 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager {
AudioManagerBase(
scoped_refptr<base::SingleThreadTaskRunner> task_runner,
scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
- AudioLogFactory* audio_log_factory);
+ AudioLogFactory* audio_log_factory,
+ CreateAudioFileWriterCallback create_audio_file_writer_callback);
// Releases all the audio output dispatchers.
// All audio streams should be closed before Shutdown() is called.
@@ -166,6 +174,9 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager {
std::string GetGroupIDOutput(const std::string& output_device_id);
std::string GetGroupIDInput(const std::string& input_device_id);
+ base::FilePath GetDebugRecordingFileNameWithExtension(
+ const base::FilePath& file_name);
+
// Max number of open output streams, modified by
// SetMaxOutputStreamsAllowed().
int max_num_output_streams_;
@@ -179,6 +190,9 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager {
// Track output state change listeners.
base::ObserverList<AudioDeviceListener> output_listeners_;
+ // Contains output resamplers. Used for controlling debug recording.
+ std::unordered_set<AudioOutputResampler*> output_resamplers_;
+
// Contains currently open input streams.
std::unordered_set<AudioInputStream*> input_streams_;
@@ -189,6 +203,13 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager {
// Proxy for creating AudioLog objects.
AudioLogFactory* const audio_log_factory_;
+ // Callback for creating AudioFileWriter objects.
+ CreateAudioFileWriterCallback create_audio_file_writer_callback_;
+
+ // The base file name for debug recording files. If this is non-empty, debug
+ // recording is enabled, otherwise disabled.
+ base::FilePath debug_recording_base_file_name_;
+
DISALLOW_COPY_AND_ASSIGN(AudioManagerBase);
};

Powered by Google App Engine
This is Rietveld 408576698