ui::Compositor needs a valid FrameSinkId even when it doesn't have ContextFactoryPrivate.

ui::Compositor needs a valid FrameSinkId even when it doesn't have ContextFactoryPrivate.

BUG=672943
Committed: https://crrev.com/f11613b422d81174773faae3368445018b67b060
Cr-Commit-Position: refs/heads/master@{#439247}

[mfomitchev, 2016-12-15 21:56:03]

mfomitchev@chromium.org changed reviewers:
+ fsamuel@chromium.org, sadrul@chromium.org

[mfomitchev, 2016-12-15 21:56:03]

PTAL

[sadrul, 2016-12-16 02:29:09]

https://codereview.chromium.org/2582653002/diff/1/ui/compositor/compositor.cc
File ui/compositor/compositor.cc (right):

https://codereview.chromium.org/2582653002/diff/1/ui/compositor/compositor.cc...
ui/compositor/compositor.cc:88: : cc::FrameSinkId(1, 1)),
Let's have a kDefaultFrameSinkId for this. So something like:

  constexpr cc::FrameSinkId kDefaultFrameSinkId(1, 1);

up in the anon namespace. And add a comment explaining why we need a valid
sink-id here.

[mfomitchev, 2016-12-16 18:17:58]

https://codereview.chromium.org/2582653002/diff/1/ui/compositor/compositor.cc
File ui/compositor/compositor.cc (right):

https://codereview.chromium.org/2582653002/diff/1/ui/compositor/compositor.cc...
ui/compositor/compositor.cc:88: : cc::FrameSinkId(1, 1)),
On 2016/12/16 02:29:09, sadrul wrote:
> Let's have a kDefaultFrameSinkId for this. So something like:
> 
>   constexpr cc::FrameSinkId kDefaultFrameSinkId(1, 1);
> 
> up in the anon namespace. And add a comment explaining why we need a valid
> sink-id here.

Done.

[Fady Samuel, 2016-12-16 18:19:58]

reluctant lgtm.

[sadrul, 2016-12-16 20:17:28]

lgtm

https://codereview.chromium.org/2582653002/diff/20001/ui/compositor/composito...
File ui/compositor/compositor.cc (right):

https://codereview.chromium.org/2582653002/diff/20001/ui/compositor/composito...
ui/compositor/compositor.cc:49: // TODO(mfomitchev, fsamuel): Looks at removing
this when transition from
*Look

[mfomitchev, 2016-12-16 20:49:45]

https://codereview.chromium.org/2582653002/diff/20001/ui/compositor/composito...
File ui/compositor/compositor.cc (right):

https://codereview.chromium.org/2582653002/diff/20001/ui/compositor/composito...
ui/compositor/compositor.cc:49: // TODO(mfomitchev, fsamuel): Looks at removing
this when transition from
On 2016/12/16 20:17:28, sadrul wrote:
> *Look

Done.

[mfomitchev, 2016-12-16 20:49:52]

The CQ bit was checked by mfomitchev@chromium.org

[mfomitchev, 2016-12-16 20:49:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2582653002/#ps40001
(title: "Fix TODO")

[commit-bot: I haz the power, 2016-12-16 20:50:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 00:16:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481921392106280,
"parent_rev": "513d7812fe8712e627f4b69ae3a216583fb1da2a", "commit_rev":
"4ad81d064676293fc00fa5a8faaa2a08addf0ea1"}

[commit-bot: I haz the power, 2016-12-17 00:17:14]

Description was changed from

==========
ui::Compositor needs a valid FrameSinkId even when it doesn't have
ContextFactoryPrivate.

BUG=672943
==========

to

==========
ui::Compositor needs a valid FrameSinkId even when it doesn't have
ContextFactoryPrivate.

BUG=672943

Review-Url: https://codereview.chromium.org/2582653002
==========

[commit-bot: I haz the power, 2016-12-17 00:17:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-17 00:19:39]

Description was changed from

==========
ui::Compositor needs a valid FrameSinkId even when it doesn't have
ContextFactoryPrivate.

BUG=672943

Review-Url: https://codereview.chromium.org/2582653002
==========

to

==========
ui::Compositor needs a valid FrameSinkId even when it doesn't have
ContextFactoryPrivate.

BUG=672943

Committed: https://crrev.com/f11613b422d81174773faae3368445018b67b060
Cr-Commit-Position: refs/heads/master@{#439247}
==========

[commit-bot: I haz the power, 2016-12-17 00:19:40]

Patchset 3 (id:??) landed as
https://crrev.com/f11613b422d81174773faae3368445018b67b060
Cr-Commit-Position: refs/heads/master@{#439247}