Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2582643002:
MD Settings: Fix scrolling when navigating Forwards from BASIC page. (Closed)
|
Created:
4 years ago by tommycli Modified:
4 years ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Fix scrolling when navigating Forwards from BASIC page.
CL includes test.
BUG=673937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/8bc347f4d307c8a7c8e6f6664895dbf4c5af288a
Cr-Commit-Position: refs/heads/master@{#439263}
Patch Set 1 #
Total comments: 2
Patch Set 2 : update comments #Patch Set 3 : change code #
Messages
Total messages: 24 (15 generated)
Description was changed from ========== MD Settings: Fix scrolling when navigating Forwards from BASIC page. CL includes test. BUG=673937 ========== to ========== MD Settings: Fix scrolling when navigating Forwards from BASIC page. CL includes test. BUG=673937 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
tommycli@chromium.org changed reviewers: + dbeam@chromium.org
dbeam: PTAL, thanks!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2582643002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/2582643002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/main_page_behavior.js:54: oldRoute == settings.Route.BASIC; can you explain why?
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
dbeam: Thanks! https://codereview.chromium.org/2582643002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/2582643002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/main_page_behavior.js:54: oldRoute == settings.Route.BASIC; On 2016/12/16 00:59:59, Dan Beam wrote: > can you explain why? Done. Refactored a bit and expanded comment.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by tommycli@chromium.org
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481935435405570,
"parent_rev": "f9398d5d02f7aa801475bf3f89f38b2132e1dc23", "commit_rev":
"0b3bbaf627b76e2989dbdc18fb458669a89efa47"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Fix scrolling when navigating Forwards from BASIC page. CL includes test. BUG=673937 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Fix scrolling when navigating Forwards from BASIC page. CL includes test. BUG=673937 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2582643002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Fix scrolling when navigating Forwards from BASIC page. CL includes test. BUG=673937 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2582643002 ========== to ========== MD Settings: Fix scrolling when navigating Forwards from BASIC page. CL includes test. BUG=673937 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8bc347f4d307c8a7c8e6f6664895dbf4c5af288a Cr-Commit-Position: refs/heads/master@{#439263} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/8bc347f4d307c8a7c8e6f6664895dbf4c5af288a Cr-Commit-Position: refs/heads/master@{#439263} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
