Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2582623002: Revert of [wasm] simpler detection if we compiled asm-wasm (Closed)

Created:
4 years ago by Mircea Trofin
Modified:
4 years ago
Reviewers:
bradnelson, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] simpler detection if we compiled asm-wasm (patchset #1 id:1 of https://codereview.chromium.org/2582583002/ ) Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/10384 Original issue's description: > [wasm] simpler detection if we compiled asm-wasm > > BUG=643595 > > Review-Url: https://codereview.chromium.org/2582583002 > Cr-Commit-Position: refs/heads/master@{#41738} > Committed: https://chromium.googlesource.com/v8/v8/+/cb433bed0b940a7073b5215e6684b940eec54edd TBR=yangguo@chromium.org,bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=643595 Review-Url: https://codereview.chromium.org/2582623002 Cr-Commit-Position: refs/heads/master@{#41739} Committed: https://chromium.googlesource.com/v8/v8/+/635edafaa6dc23dac3f28e18fcd914db667dfdbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M src/compiler.cc View 2 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Mircea Trofin
Created Revert of [wasm] simpler detection if we compiled asm-wasm
4 years ago (2016-12-15 19:35:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582623002/1
4 years ago (2016-12-15 19:35:51 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-15 19:36:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/635edafaa6dc23dac3f28e18fcd914db667...

Powered by Google App Engine
This is Rietveld 408576698