Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2582613003: Fix branding in the update prompt on Android (Closed)

Created:
4 years ago by vabr (Chromium)
Modified:
4 years ago
Reviewers:
dvadym
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix branding in the update prompt on Android Currently, the update prompt only refers to password manager as "Smart Lock" if the PasswordBranding experiment group is SmartLockBranding. The save prompt and both prompts on all other platforms (desktop + iOS) also accept the group SmartLockBrandingSavePromptOnly. This CL fixes the Android update prompt to follow the rest. R=dvadym@chromium.org BUG=674969 Committed: https://crrev.com/74b5e0999e79581da4a652b06201e92abb47ebfe Cr-Commit-Position: refs/heads/master@{#439448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/password_manager/update_password_infobar_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
vabr (Chromium)
Hi Vadym, Please review. More info on the associated bug. I discussed this change with ...
4 years ago (2016-12-16 18:54:07 UTC) #3
dvadym
LGTM
4 years ago (2016-12-19 09:38:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582613003/1
4 years ago (2016-12-19 09:49:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 10:22:08 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-19 10:24:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74b5e0999e79581da4a652b06201e92abb47ebfe
Cr-Commit-Position: refs/heads/master@{#439448}

Powered by Google App Engine
This is Rietveld 408576698