Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2049)

Issue 2582543005: [MD History] Reenable SyncedTabsTest. (Closed)

Created:
4 years ago by calamity
Modified:
4 years ago
Reviewers:
tsergeant
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Reenable SyncedTabsTest. This CL skips the focus test that is likely the cause of failures and reenables the test on all platforms. BUG=640862 Committed: https://crrev.com/dd157d9a5f102bb94928e7a2be61250e2ff43826 Cr-Commit-Position: refs/heads/master@{#439056}

Patch Set 1 #

Patch Set 2 : lol didn't save #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/test/data/webui/md_history/history_synced_tabs_test.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/webui/md_history/md_history_browsertest.js View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
calamity
4 years ago (2016-12-16 02:45:59 UTC) #2
tsergeant
Do you need to reenable it in md_history_browsertest.js?
4 years ago (2016-12-16 03:09:30 UTC) #3
calamity
On 2016/12/16 03:09:30, tsergeant wrote: > Do you need to reenable it in md_history_browsertest.js? Oops, ...
4 years ago (2016-12-16 03:10:56 UTC) #4
tsergeant
lgtm
4 years ago (2016-12-16 03:11:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582543005/20001
4 years ago (2016-12-16 03:23:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 07:06:05 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-16 07:10:07 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd157d9a5f102bb94928e7a2be61250e2ff43826
Cr-Commit-Position: refs/heads/master@{#439056}

Powered by Google App Engine
This is Rietveld 408576698