Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 2582543002: bluetooth: Remove [NoInterfaceObject] from Bluetooth interface (Closed)

Created:
4 years ago by François Beaufort
Modified:
4 years ago
CC:
blink-reviews, chromium-reviews, haraken, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Remove [NoInterfaceObject] from Bluetooth interface BUG=674540 Committed: https://crrev.com/348e99c468e81a2cd30359402221b37aeebb8cd0 Cr-Commit-Position: refs/heads/master@{#439101}

Patch Set 1 #

Patch Set 2 : Fix tests #

Total comments: 2

Patch Set 3 : Fix tests #2 #

Patch Set 4 : rebase #

Messages

Total messages: 26 (17 generated)
mlamouri (slow - plz ping)
lgtm with tests passing https://codereview.chromium.org/2582543002/diff/20001/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt File third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt (right): https://codereview.chromium.org/2582543002/diff/20001/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt#newcode348 third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt:348: method requestDevice Shouldn't you update ...
4 years ago (2016-12-16 09:21:13 UTC) #4
fbeaufortchromium
https://codereview.chromium.org/2582543002/diff/20001/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt File third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt (right): https://codereview.chromium.org/2582543002/diff/20001/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt#newcode348 third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt:348: method requestDevice On 2016/12/16 09:21:13, mlamouri wrote: > Shouldn't ...
4 years ago (2016-12-16 09:41:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582543002/60001
4 years ago (2016-12-16 12:18:05 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/327713)
4 years ago (2016-12-16 12:24:17 UTC) #16
mlamouri (slow - plz ping)
+foolip@ for the exposed interfaces change.
4 years ago (2016-12-16 14:18:47 UTC) #18
foolip
lgtm
4 years ago (2016-12-16 14:32:36 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582543002/60001
4 years ago (2016-12-16 14:32:51 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-16 14:37:18 UTC) #24
commit-bot: I haz the power
4 years ago (2016-12-16 14:39:32 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/348e99c468e81a2cd30359402221b37aeebb8cd0
Cr-Commit-Position: refs/heads/master@{#439101}

Powered by Google App Engine
This is Rietveld 408576698