Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2582523003: Fixes visibility bugs in DesktopWindowTreeHostMus (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes visibility bugs in DesktopWindowTreeHostMus Close() needs to hide right away. And the delegate wasn't notified of show/hide. BUG=674003 TEST=covered by test R=erg@chromium.org Committed: https://crrev.com/88dc5d7572db0090dbb1b14442da7d2c33efb18c Cr-Commit-Position: refs/heads/master@{#438882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M ui/views/mus/desktop_window_tree_host_mus.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/views/view_unittest.cc View 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sky
4 years ago (2016-12-15 17:41:36 UTC) #1
Elliot Glaysher
lgtm
4 years ago (2016-12-15 18:09:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582523003/1
4 years ago (2016-12-15 18:23:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 18:51:41 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-15 18:53:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88dc5d7572db0090dbb1b14442da7d2c33efb18c
Cr-Commit-Position: refs/heads/master@{#438882}

Powered by Google App Engine
This is Rietveld 408576698