[Cronet] Adjust testGetResponseAfterWriteFailed for system HUC implementation

[Cronet] Adjust testGetResponseAfterWriteFailed for system HUC implementation

System HUC implementation is flaky. This CL adjusts
testGetResponseAfterWriteFailed to run Cronet's HUC
implementation for a portion of the test.

R=pauljensen@chromium.org

BUG=653072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/7d2126e1d2d73c397a9de611ed8b4a630ca76754
Cr-Commit-Position: refs/heads/master@{#438916}

[xunjieli, 2016-12-15 15:00:08]

Description was changed from

==========
[Cronet] Disable testGetResponseAfterWriteFailed for system HUC implementation

System HUC implementation is flaky. This CL changes
testGetResponseAfterWriteFailed to only run Cronet's HUC implementation.

R=pauljensen@chromium.org

BUG=653072
==========

to

==========
[Cronet] Disable testGetResponseAfterWriteFailed for system HUC implementation

System HUC implementation is flaky. This CL changes
testGetResponseAfterWriteFailed to only run Cronet's HUC implementation.

R=pauljensen@chromium.org

BUG=653072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[xunjieli, 2016-12-15 15:01:02]

Thanks!

[pauljensen, 2016-12-15 15:40:19]

https://codereview.chromium.org/2582523002/diff/1/components/cronet/android/t...
File
components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetChunkedOutputStreamTest.java
(right):

https://codereview.chromium.org/2582523002/diff/1/components/cronet/android/t...
components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetChunkedOutputStreamTest.java:134:
fail();
since this fail() isn't really what we're trying to test, and the test passes
most of the time, how about just changing this to:
if (testingSystemHttpURLConnection()) {
    // System's implementation is flaky see crbug.com/653072
    return;
}
fail();

[xunjieli, 2016-12-15 19:32:23]

Description was changed from

==========
[Cronet] Disable testGetResponseAfterWriteFailed for system HUC implementation

System HUC implementation is flaky. This CL changes
testGetResponseAfterWriteFailed to only run Cronet's HUC implementation.

R=pauljensen@chromium.org

BUG=653072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Adjust testGetResponseAfterWriteFailed expectation for system HUC
implementation

System HUC implementation is flaky. This CL adjusts
testGetResponseAfterWriteFailed to run Cronet's HUC 
implementation for a portion of the test.

R=pauljensen@chromium.org

BUG=653072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[xunjieli, 2016-12-15 19:32:41]

Description was changed from

==========
[Cronet] Adjust testGetResponseAfterWriteFailed expectation for system HUC
implementation

System HUC implementation is flaky. This CL adjusts
testGetResponseAfterWriteFailed to run Cronet's HUC 
implementation for a portion of the test.

R=pauljensen@chromium.org

BUG=653072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Adjust testGetResponseAfterWriteFailed for system HUC implementation

System HUC implementation is flaky. This CL adjusts
testGetResponseAfterWriteFailed to run Cronet's HUC 
implementation for a portion of the test.

R=pauljensen@chromium.org

BUG=653072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[xunjieli, 2016-12-15 19:33:18]

Thanks! PTAL.

https://codereview.chromium.org/2582523002/diff/1/components/cronet/android/t...
File
components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetChunkedOutputStreamTest.java
(right):

https://codereview.chromium.org/2582523002/diff/1/components/cronet/android/t...
components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetChunkedOutputStreamTest.java:134:
fail();
On 2016/12/15 15:40:19, pauljensen wrote:
> since this fail() isn't really what we're trying to test, and the test passes
> most of the time, how about just changing this to:
> if (testingSystemHttpURLConnection()) {
>     // System's implementation is flaky see crbug.com/653072
>     return;
> }
> fail();

Done. The getResponseCode() below should fail for both implementation so I
didn't use early return.

[pauljensen, 2016-12-15 19:39:45]

lgtm

[xunjieli, 2016-12-15 19:40:49]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2016-12-15 19:41:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 20:44:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481830849366480,
"parent_rev": "3eea1bfe8f22c44537e9a94d2a623b63466b90fa", "commit_rev":
"959b4cd2181e189acaec8067d008e55fd4e6d356"}

[commit-bot: I haz the power, 2016-12-15 20:44:29]

Description was changed from

==========
[Cronet] Adjust testGetResponseAfterWriteFailed for system HUC implementation

System HUC implementation is flaky. This CL adjusts
testGetResponseAfterWriteFailed to run Cronet's HUC 
implementation for a portion of the test.

R=pauljensen@chromium.org

BUG=653072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Adjust testGetResponseAfterWriteFailed for system HUC implementation

System HUC implementation is flaky. This CL adjusts
testGetResponseAfterWriteFailed to run Cronet's HUC 
implementation for a portion of the test.

R=pauljensen@chromium.org

BUG=653072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2582523002
==========

[commit-bot: I haz the power, 2016-12-15 20:44:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-15 20:48:10]

Description was changed from

==========
[Cronet] Adjust testGetResponseAfterWriteFailed for system HUC implementation

System HUC implementation is flaky. This CL adjusts
testGetResponseAfterWriteFailed to run Cronet's HUC 
implementation for a portion of the test.

R=pauljensen@chromium.org

BUG=653072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2582523002
==========

to

==========
[Cronet] Adjust testGetResponseAfterWriteFailed for system HUC implementation

System HUC implementation is flaky. This CL adjusts
testGetResponseAfterWriteFailed to run Cronet's HUC
implementation for a portion of the test.

R=pauljensen@chromium.org

BUG=653072
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/7d2126e1d2d73c397a9de611ed8b4a630ca76754
Cr-Commit-Position: refs/heads/master@{#438916}
==========

[commit-bot: I haz the power, 2016-12-15 20:48:11]

Patchset 2 (id:??) landed as
https://crrev.com/7d2126e1d2d73c397a9de611ed8b4a630ca76754
Cr-Commit-Position: refs/heads/master@{#438916}