Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3549)

Unified Diff: chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

Issue 2582503002: Disable BlockWebContentsCreationIncognito test on ASAN on Mac. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
diff --git a/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc b/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
index 6a01a1da89d441685dc02258d841b3e8362c8234..e11a1e086a847af9da869f6f90cbe0d000b56652 100644
--- a/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
+++ b/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
@@ -250,8 +250,16 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
DontCheckTitle);
}
+#if defined(OS_MACOSX) && defined(ADDRESS_SANITIZER)
+// Flaky on ASAN on Mac. See https://crbug.com/674497.
+#define MAYBE_BlockWebContentsCreationIncognito \
+ DISABLED_BlockWebContentsCreationIncognito
+#else
+#define MAYBE_BlockWebContentsCreationIncognito \
+ BlockWebContentsCreationIncognito
+#endif
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
- BlockWebContentsCreationIncognito) {
+ MAYBE_BlockWebContentsCreationIncognito) {
RunCheckTest(
CreateIncognitoBrowser(),
"/popup_blocker/popup-blocked-to-post-blank.html",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698