Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

Issue 2582503002: Disable BlockWebContentsCreationIncognito test on ASAN on Mac. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 243
244 IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, 244 IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
245 BlockWebContentsCreation) { 245 BlockWebContentsCreation) {
246 RunCheckTest( 246 RunCheckTest(
247 browser(), 247 browser(),
248 "/popup_blocker/popup-blocked-to-post-blank.html", 248 "/popup_blocker/popup-blocked-to-post-blank.html",
249 ExpectTab, 249 ExpectTab,
250 DontCheckTitle); 250 DontCheckTitle);
251 } 251 }
252 252
253 #if defined(OS_MACOSX) && defined(ADDRESS_SANITIZER)
254 // Flaky on ASAN on Mac. See https://crbug.com/674497.
255 #define MAYBE_BlockWebContentsCreationIncognito \
256 DISABLED_BlockWebContentsCreationIncognito
257 #else
258 #define MAYBE_BlockWebContentsCreationIncognito \
259 BlockWebContentsCreationIncognito
260 #endif
253 IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, 261 IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
254 BlockWebContentsCreationIncognito) { 262 MAYBE_BlockWebContentsCreationIncognito) {
255 RunCheckTest( 263 RunCheckTest(
256 CreateIncognitoBrowser(), 264 CreateIncognitoBrowser(),
257 "/popup_blocker/popup-blocked-to-post-blank.html", 265 "/popup_blocker/popup-blocked-to-post-blank.html",
258 ExpectTab, 266 ExpectTab,
259 DontCheckTitle); 267 DontCheckTitle);
260 } 268 }
261 269
262 IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, 270 IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
263 PopupBlockedFakeClickOnAnchor) { 271 PopupBlockedFakeClickOnAnchor) {
264 RunCheckTest( 272 RunCheckTest(
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
709 717
710 wait_for_new_tab.Wait(); 718 wait_for_new_tab.Wait();
711 719
712 ASSERT_EQ(1u, chrome::GetBrowserCount(browser()->profile())); 720 ASSERT_EQ(1u, chrome::GetBrowserCount(browser()->profile()));
713 ASSERT_EQ(2, browser()->tab_strip_model()->count()); 721 ASSERT_EQ(2, browser()->tab_strip_model()->count());
714 // Check that we create the background tab. 722 // Check that we create the background tab.
715 ASSERT_EQ(0, browser()->tab_strip_model()->active_index()); 723 ASSERT_EQ(0, browser()->tab_strip_model()->active_index());
716 } 724 }
717 725
718 } // namespace 726 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698