[runtime] Throw if attempting to re-declaring an accessor.

[runtime] Throw if re-declaring a non-configurable accessor.

If an accessor property is non-configurable, one should not be able
to re-declare it as a function. This specifically applies to special properties like window.location.


BUG=chromium:670596
Review-Url: https://codereview.chromium.org/2582493002
Cr-Commit-Position: refs/heads/master@{#41725}
Committed: https://chromium.googlesource.com/v8/v8/+/0e7a2ca0d75fad836435b0836ccc13c2b128e2f3

[Franzi, 2016-12-15 13:20:04]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 13:20:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Franzi, 2016-12-15 13:20:44]

Description was changed from

==========
[runtime] Throw if attempting to re-declaring an accessor.


BUG=chromium:670596
==========

to

==========
[runtime] Throw if re-declaring a non-configurable accessor.


BUG=chromium:670596
==========

[commit-bot: I haz the power, 2016-12-15 13:45:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 13:45:01]

Dry run: This issue passed the CQ dry run.

[Franzi, 2016-12-15 13:56:06]

Patchset #2 (id:20001) has been deleted

[Franzi, 2016-12-15 14:13:10]

Description was changed from

==========
[runtime] Throw if re-declaring a non-configurable accessor.


BUG=chromium:670596
==========

to

==========
[runtime] Throw if re-declaring a non-configurable accessor.

If an accessor property is non-configurable, one should not be able
to re-declare it as a function. This specifically applies to special properties
like window.location.


BUG=chromium:670596
==========

[Franzi, 2016-12-15 14:13:20]

franzih@chromium.org changed reviewers:
+ jochen@chromium.org, yukishiino@chromium.org

[Franzi, 2016-12-15 14:13:21]

Hi, 

please take a look. 

Thanks, 

Franzi

[jochen (gone - plz use gerrit), 2016-12-15 14:14:42]

lgtm

[Franzi, 2016-12-15 14:15:22]

The CQ bit was checked by franzih@chromium.org

[commit-bot: I haz the power, 2016-12-15 14:15:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 14:41:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481811322329880,
"parent_rev": "af6d01a168c8c61f096edf4e54e97add97f36deb", "commit_rev":
"0e7a2ca0d75fad836435b0836ccc13c2b128e2f3"}

[commit-bot: I haz the power, 2016-12-15 14:41:10]

Description was changed from

==========
[runtime] Throw if re-declaring a non-configurable accessor.

If an accessor property is non-configurable, one should not be able
to re-declare it as a function. This specifically applies to special properties
like window.location.


BUG=chromium:670596
==========

to

==========
[runtime] Throw if re-declaring a non-configurable accessor.

If an accessor property is non-configurable, one should not be able
to re-declare it as a function. This specifically applies to special properties
like window.location.


BUG=chromium:670596

Review-Url: https://codereview.chromium.org/2582493002
Cr-Commit-Position: refs/heads/master@{#41725}
Committed:
https://chromium.googlesource.com/v8/v8/+/0e7a2ca0d75fad836435b0836ccc13c2b12...
==========

[commit-bot: I haz the power, 2016-12-15 14:41:11]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/0e7a2ca0d75fad836435b0836ccc13c2b12...

[Yuki, 2016-12-16 06:37:01]

I don't know details of V8 implementation, but rs-lgtm.  Thanks for fixing this.