Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: src/ic.cc

Issue 258243003: Remove old-style accessor support from runtime. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/accessors.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index 09444b337aba82437c5c4b80ea8b37fd7ad0ab7c..f02a704609e23d46db2e58a8b55d1ddc61a81d66 100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -1032,8 +1032,7 @@ Handle<Code> LoadIC::CompileHandler(LookupResult* lookup,
}
// TODO(dcarney): Handle correctly.
if (callback->IsDeclaredAccessorInfo()) break;
- ASSERT(callback->IsForeign());
- // No IC support for old-style native accessors.
+ UNREACHABLE();
Yang 2014/04/29 10:43:12 We could also just ASSERT(callback->IsDeclaredAcce
break;
}
case INTERCEPTOR:
@@ -1457,19 +1456,7 @@ Handle<Code> StoreIC::CompileHandler(LookupResult* lookup,
}
// TODO(dcarney): Handle correctly.
if (callback->IsDeclaredAccessorInfo()) break;
- ASSERT(callback->IsForeign());
-
- // Use specialized code for setting the length of arrays with fast
- // properties. Slow properties might indicate redefinition of the length
- // property.
- if (receiver->IsJSArray() &&
- String::Equals(isolate()->factory()->length_string(), name) &&
- Handle<JSArray>::cast(receiver)->AllowsSetElementsLength() &&
- receiver->HasFastProperties()) {
- return compiler.CompileStoreArrayLength(receiver, lookup, name);
- }
-
- // No IC support for old-style native accessors.
+ UNREACHABLE();
Yang 2014/04/29 10:43:12 Ditto.
break;
}
case INTERCEPTOR:
« no previous file with comments | « src/accessors.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698