Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2582413002: Get rid of @font-face resource leak. (Closed)

Created:
4 years ago by rune
Modified:
4 years ago
Reviewers:
meade_UTC10, sof
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of @font-face resource leak. Clear the StyleEngine of css connected fonts on detach(). This used to be saved by an active stylesheet update, it seems. With the new active stylesheet update this is done more selectively and it might have been done when document going inactive before. Clearing the font cache on detach fixes the leak issues in css3/fonts. TEST=css3/fonts/ BUG=674934 Committed: https://crrev.com/357396ffe3cc7ace113783f25e088d08e615b08b Cr-Commit-Position: refs/heads/master@{#439510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
rune
4 years ago (2016-12-19 15:39:48 UTC) #4
sof
lgtm
4 years ago (2016-12-19 16:04:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582413002/1
4 years ago (2016-12-19 18:34:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 18:40:10 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-19 18:42:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/357396ffe3cc7ace113783f25e088d08e615b08b
Cr-Commit-Position: refs/heads/master@{#439510}

Powered by Google App Engine
This is Rietveld 408576698