third_party/WebKit/Source/core/layout/LayoutGrid.cpp - Issue 2582363002: [css-grid] Fix positioning of positioned grid children

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Issue 2582363002: [css-grid] Fix positioning of positioned grid children (Closed)

Patch Set: Improved test v2 Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

index 6aed9bbb19ad6c2026681eb1077fc704050868bc..ac08e774401aa3279283f0381f9c7d4476ba68f9 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

@@ -2612,9 +2612,6 @@ void LayoutGrid::layoutPositionedObjects(bool relayoutChildren,

return;

for (auto* child : *positionedDescendants) {

- if (!child->needsLayout())

- continue;

if (isOrthogonalChild(*child)) {

// FIXME: Properly support orthogonal writing mode.

continue;