Chromium Code Reviews Chromium Code Reviews
Issue 2582363002:
[css-grid] Fix positioning of positioned grid children (Closed)
| Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-paint-positioned-children.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-paint-positioned-children.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-paint-positioned-children.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..5e6277b608f472ef2fb3ae8c6dc6468920502f01 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-paint-positioned-children.html |
| @@ -0,0 +1,32 @@ |
| +<!DOCTYPE html> |
| +<link href="resources/grid.css" rel="stylesheet"> |
| +<link rel="match" href="grid-paint-positioned-children-expected.html"> |
| +<style> |
| +.grid { |
| + display: grid; |
|
Manuel Rego
2016/12/19 11:56:07
Nit: You don't need this line.
|
| + border: 2px solid black; |
| + position: relative; |
| + width: 100px; |
| + |
| + grid-template-columns: 10px 20px 30px 40px; |
| + grid-auto-columns: 20px; |
|
Manuel Rego
2016/12/19 11:56:07
I guess you don't need this line.
|
| + |
| + padding-top: 10px; |
| +} |
| + |
| +.abs { height: 5px; position: absolute; width: 100%; } |
|
Manuel Rego
2016/12/19 11:56:07
Nit: Why only 1 line here and not in the other?
|
| + |
| +#item { |
| + width: 90px; |
| + height: 30px; |
|
Manuel Rego
2016/12/19 11:56:07
Nit: Indentation here doesn't match the rest of th
|
| +} |
| + |
| +</style> |
| + |
|
Manuel Rego
2016/12/19 11:56:07
The ref-tests usually have a sentence explaining
h
|
| +<div class="grid"> |
| + <div id="item" style="grid-column: 1 / -1; background: cyan;"></div> |
| + <div class="abs" style="grid-column: 1 / 2; background: purple;"></div> |
| + <div class="abs" style="grid-column: 2 / 3; background: orange;"></div> |
| + <div class="abs" style="grid-column: 3 / 4; background: yellow;"></div> |
| + <div class="abs" style="grid-column: 4 / 5; background: magenta;"></div> |
| +</div> |
