Migrate static transport security state fuzzer to LibFuzzer.

Migrate static transport security state fuzzer to LibFuzzer.

BUG=599523
Committed: https://crrev.com/da9407983d1d996042e8f3303035f40f3ae2758b
Cr-Commit-Position: refs/heads/master@{#440922}

[martijnc, 2016-12-19 23:18:52]

Description was changed from

==========
Migrate static transport security fuzzer to LibFuzzer.

BUG=599523
==========

to

==========
Migrate static transport security state fuzzer to LibFuzzer.

BUG=599523
==========

[martijnc, 2016-12-28 18:08:31]

Patchset #1 (id:1) has been deleted

[martijnc, 2016-12-28 23:59:56]

martijn@martijnc.be changed reviewers:
+ rsleevi@chromium.org

[martijnc, 2016-12-28 23:59:57]

Moving the fuzzing to ClusterFuzz will give us reproducible inputs for failures
so that seems like a good idea.

One question; according to the docs the fuzzers are updated daily so the builds
should always be timely, but I think there were some issues recently with bots
having incorrect clocks and timely builds not being seen as timely because of
that. Should there be an override for IsBuildTimely() as well?

[Ryan Sleevi, 2016-12-29 00:14:37]

On 2016/12/28 23:59:57, martijnc wrote:
> One question; according to the docs the fuzzers are updated daily so the
builds
> should always be timely, but I think there were some issues recently with bots
> having incorrect clocks and timely builds not being seen as timely because of
> that.

Right, that's an infrastructure issue (for Android n5x bots)

> Should there be an override for IsBuildTimely() as well?

No, we shouldn't hack around infrastructure issues in code - as the code lives
on well after the infrastructure doesn't. At least, "no" for this reason.

[Ryan Sleevi, 2016-12-29 00:16:52]

https://codereview.chromium.org/2582323004/diff/20001/net/http/transport_secu...
File net/http/transport_security_state_static_fuzzer.cc (right):

https://codereview.chromium.org/2582323004/diff/20001/net/http/transport_secu...
net/http/transport_security_state_static_fuzzer.cc:39: std::string input(data,
data + size);
This doesn't give casting errors? uint8_t* is a different type than char* - I
would expect a reinterpret_cast<> needed here.

[martijnc, 2016-12-29 00:30:11]

https://codereview.chromium.org/2582323004/diff/20001/net/http/transport_secu...
File net/http/transport_security_state_static_fuzzer.cc (right):

https://codereview.chromium.org/2582323004/diff/20001/net/http/transport_secu...
net/http/transport_security_state_static_fuzzer.cc:39: std::string input(data,
data + size);
On 2016/12/29 at 00:16:51, Ryan Sleevi wrote:
> This doesn't give casting errors? uint8_t* is a different type than char* - I
would expect a reinterpret_cast<> needed here.

You're right. Done.

I noticed the Linux compiler doesn't always complain about this but the Windows
compiler does.

[Ryan Sleevi, 2016-12-29 00:35:39]

LGTM % nit

https://codereview.chromium.org/2582323004/diff/40001/net/http/transport_secu...
File net/http/transport_security_state_static_fuzzer.cc (right):

https://codereview.chromium.org/2582323004/diff/40001/net/http/transport_secu...
net/http/transport_security_state_static_fuzzer.cc:4: #include <iostream>
This wasn't necessary, was it?

If so, line break between 3 & 4, but from reading, I think it should be fine to
nuke?

[martijnc, 2016-12-29 00:39:32]

The CQ bit was checked by martijn@martijnc.be

[martijnc, 2016-12-29 00:39:32]

https://codereview.chromium.org/2582323004/diff/40001/net/http/transport_secu...
File net/http/transport_security_state_static_fuzzer.cc (right):

https://codereview.chromium.org/2582323004/diff/40001/net/http/transport_secu...
net/http/transport_security_state_static_fuzzer.cc:4: #include <iostream>
On 2016/12/29 at 00:35:38, Ryan Sleevi wrote:
> This wasn't necessary, was it?
> 
> If so, line break between 3 & 4, but from reading, I think it should be fine
to nuke?

Yes, sorry, forgot to remove it again.

[martijnc, 2016-12-29 00:39:33]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2582323004/#ps60001
(title: "Remove include.")

[commit-bot: I haz the power, 2016-12-29 00:39:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 01:36:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482971972422720,
"parent_rev": "0d998a2dfc184cf81cf4a23ce4870d2e889e0947", "commit_rev":
"e9d507557a826b9c192700d3dca17943c71e2d63"}

[commit-bot: I haz the power, 2016-12-29 01:37:27]

Description was changed from

==========
Migrate static transport security state fuzzer to LibFuzzer.

BUG=599523
==========

to

==========
Migrate static transport security state fuzzer to LibFuzzer.

BUG=599523

Review-Url: https://codereview.chromium.org/2582323004
==========

[commit-bot: I haz the power, 2016-12-29 01:37:28]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2017-01-02 15:51:19]

Description was changed from

==========
Migrate static transport security state fuzzer to LibFuzzer.

BUG=599523

Review-Url: https://codereview.chromium.org/2582323004
==========

to

==========
Migrate static transport security state fuzzer to LibFuzzer.

BUG=599523

Committed: https://crrev.com/da9407983d1d996042e8f3303035f40f3ae2758b
Cr-Commit-Position: refs/heads/master@{#440922}
==========

[commit-bot: I haz the power, 2017-01-02 15:51:20]

Patchset 3 (id:??) landed as
https://crrev.com/da9407983d1d996042e8f3303035f40f3ae2758b
Cr-Commit-Position: refs/heads/master@{#440922}