Remove use of wdiff from layout test runner.

Remove use of wdiff from layout test runner.

Now, after http://crrev.com/2580343003, HTML diffs are available on all platforms, and dependency on wdiff can be removed.

BUG=672651
Review-Url: https://codereview.chromium.org/2582293004
Cr-Commit-Position: refs/heads/master@{#443391}
Committed: https://chromium.googlesource.com/chromium/src/+/fa4d63fe4de1c958b38ca404fffeeab5f883bfa7

[qyearsley, 2016-12-19 23:19:53]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-12-20 22:23:46]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 22:24:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 00:39:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:39:11]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-12-28 02:48:55]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 02:49:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 04:11:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 04:11:23]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-12-29 21:31:38]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 21:31:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 22:35:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 22:35:16]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[qyearsley, 2017-01-03 22:22:20]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 22:22:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 00:00:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 00:00:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[qyearsley, 2017-01-10 23:48:15]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 23:48:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 01:29:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:29:36]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2017-01-12 18:28:46]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 18:29:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-01-12 18:30:12]

Description was changed from

==========
Remove use of wdiff from layout test runner.

Before removing wdiff, we should make sure that we can reliably get HTML
diffs using html_diff on all platforms, so http://crrev.com/2580343003
should be committed and verified before thsi CL is committed.

But, does this look like what we want to do? (This CL basically just
removes all mentions of "wdiff" from everywhere).

BUG=672651
==========

to

==========
Remove use of wdiff from layout test runner.

Now, after http://crrev.com/2580343003, HTML diffs are available on all
platforms, and dependency on wdiff can be removed.

BUG=672651
==========

[qyearsley, 2017-01-12 18:30:12]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2017-01-12 18:33:25]

This CL is now ready to review; there are now line-based HTML diffs on all
platforms (e.g.
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7/4951...)
- any reason not to remove wdiff now?

[Dirk Pranke, 2017-01-12 18:37:42]

lgtm!

[jeffcarp, 2017-01-12 18:59:38]

lgtm

[qyearsley, 2017-01-12 19:12:13]

The CQ bit was unchecked by qyearsley@chromium.org

[qyearsley, 2017-01-12 19:12:16]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-01-12 19:12:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 22:42:05]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484248336297280,
"parent_rev": "e9408cc6c29f9476a7a76d07ecefc6f1d7b3fcdb", "commit_rev":
"fa4d63fe4de1c958b38ca404fffeeab5f883bfa7"}

[commit-bot: I haz the power, 2017-01-12 22:42:44]

Description was changed from

==========
Remove use of wdiff from layout test runner.

Now, after http://crrev.com/2580343003, HTML diffs are available on all
platforms, and dependency on wdiff can be removed.

BUG=672651
==========

to

==========
Remove use of wdiff from layout test runner.

Now, after http://crrev.com/2580343003, HTML diffs are available on all
platforms, and dependency on wdiff can be removed.

BUG=672651

Review-Url: https://codereview.chromium.org/2582293004
Cr-Commit-Position: refs/heads/master@{#443391}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa4d63fe4de1c958b38ca404fffe...
==========

[commit-bot: I haz the power, 2017-01-12 22:42:45]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/fa4d63fe4de1c958b38ca404fffe...