Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issue 2582263003: [Android] Fix empty gtest test name parsing. (Closed)

Created:
4 years ago by jbudorick
Modified:
4 years ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix empty gtest test name parsing. Last week, a CL landed that contained a gtest with an empty test name, e.g. TEST(FooTest, ) This broke our gtest-list-tests parsing logic because it saw this: FooTest. testBar and incorrectly handled the line containing only spaces. This patch fixes the handling of that case. Committed: https://crrev.com/ef60bcc9540eaad70582a14267ba0d7998f9fd87 Cr-Commit-Position: refs/heads/master@{#439507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M build/android/pylib/gtest/gtest_test_instance.py View 1 chunk +6 lines, -4 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance_test.py View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jbudorick
4 years ago (2016-12-19 17:23:54 UTC) #2
rnephew (Reviews Here)
On 2016/12/19 17:23:54, jbudorick wrote: lgtm
4 years ago (2016-12-19 17:26:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582263003/1
4 years ago (2016-12-19 17:29:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 18:33:43 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-19 18:35:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef60bcc9540eaad70582a14267ba0d7998f9fd87
Cr-Commit-Position: refs/heads/master@{#439507}

Powered by Google App Engine
This is Rietveld 408576698