Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2582173002: Use MockResource instead of ImageResource in FrameFetchContextTest.cpp (Closed)

Created:
4 years ago by hiroshige
Modified:
3 years, 11 months ago
CC:
chromium-reviews, Yoav Weiss, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use MockResource instead of ImageResource in FrameFetchContextTest.cpp BUG= Committed: https://crrev.com/bae5ac22d3b6ec71bf6921506a7a3e7b4c1184df Cr-Commit-Position: refs/heads/master@{#440807}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
hiroshige
PTAL.
4 years ago (2016-12-17 06:41:13 UTC) #6
Takashi Toyoshima
lgtm
4 years ago (2016-12-19 10:29:50 UTC) #7
yhirano
lgtm
4 years ago (2016-12-19 11:31:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582173002/20001
3 years, 12 months ago (2016-12-27 22:40:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-27 23:43:49 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:47:52 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bae5ac22d3b6ec71bf6921506a7a3e7b4c1184df
Cr-Commit-Position: refs/heads/master@{#440807}

Powered by Google App Engine
This is Rietveld 408576698