Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2582143002: chromeos: Move removable media path constant to header. (Closed)

Created:
4 years ago by Daniel Erat
Modified:
4 years ago
Reviewers:
hirono
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Move removable media path constant to header. Move the file manager kRemovableMediaPath constant to a header so it can be used by tests. BUG=633243 Committed: https://crrev.com/77e83af4dd9d2233ee01879a0514c73011a8459f Cr-Commit-Position: refs/heads/master@{#439401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/browser/chromeos/file_manager/path_util.h View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_manager/path_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Daniel Erat
4 years ago (2016-12-17 00:46:41 UTC) #2
hirono
lgtm!
4 years ago (2016-12-19 00:29:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582143002/1
4 years ago (2016-12-19 03:34:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 04:01:32 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-19 04:03:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77e83af4dd9d2233ee01879a0514c73011a8459f
Cr-Commit-Position: refs/heads/master@{#439401}

Powered by Google App Engine
This is Rietveld 408576698