Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2582133002: Add DependsOn() calls to PrecacheManagerFactory. (Closed)

Created:
4 years ago by twifkak
Modified:
4 years ago
Reviewers:
bengr
CC:
chromium-reviews, wifiprefetch-reviews_google.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DependsOn() calls to PrecacheManagerFactory. Add dependencies on ProfileSyncServiceFactory, HistoryServiceFactory, and DataReductionProxyChromeSettingsFactory, to match the usage in BuildServiceInstanceFor. BUG=675794 Committed: https://crrev.com/44dbf999f94cfba6c40ceadd4f4ed9b5f4a1eca2 Cr-Commit-Position: refs/heads/master@{#439653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/precache/precache_manager_factory.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
twifkak
4 years ago (2016-12-17 00:09:44 UTC) #2
bengr
lgtm. Please file a bug and refer to it in this CL to simplify tracking ...
4 years ago (2016-12-20 00:43:53 UTC) #3
twifkak
On 2016/12/20 00:43:53, bengr wrote: > lgtm. Please file a bug and refer to it ...
4 years ago (2016-12-20 00:51:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582133002/1
4 years ago (2016-12-20 00:52:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 01:27:11 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-20 01:29:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44dbf999f94cfba6c40ceadd4f4ed9b5f4a1eca2
Cr-Commit-Position: refs/heads/master@{#439653}

Powered by Google App Engine
This is Rietveld 408576698