Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2582063002: Revert of Support saturation overrides in saturated_cast (Closed)

Created:
4 years ago by agrieve
Modified:
4 years ago
Reviewers:
jschuh, eae
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support saturation overrides in saturated_cast (patchset #7 id:180001 of https://codereview.chromium.org/2578613002/ ) Reason for revert: Suspect breaking base_unittests (missing test name in unittest macro). https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/38202 Original issue's description: > Support saturation overrides in saturated_cast > > This is a requirement for adding a full saturated type implementation. > > BUG=672489 > NOTRY=true > > Committed: https://crrev.com/186c7dbbea5eef852bf0c4277d1da16f56f9156e > Cr-Commit-Position: refs/heads/master@{#439061} TBR=eae@chromium.org,jschuh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672489, 674849 Committed: https://crrev.com/7772a0500fa206d81a4a7fb00c92934eeb609b50 Cr-Commit-Position: refs/heads/master@{#439150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -161 lines) Patch
M base/numerics/safe_conversions.h View 3 chunks +63 lines, -48 lines 0 comments Download
M base/numerics/safe_conversions_impl.h View 2 chunks +19 lines, -65 lines 0 comments Download
M base/numerics/safe_numerics_unittest.cc View 3 chunks +10 lines, -48 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
agrieve
Created Revert of Support saturation overrides in saturated_cast
4 years ago (2016-12-16 18:16:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582063002/1
4 years ago (2016-12-16 18:18:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 18:19:25 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-16 18:22:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7772a0500fa206d81a4a7fb00c92934eeb609b50
Cr-Commit-Position: refs/heads/master@{#439150}

Powered by Google App Engine
This is Rietveld 408576698