Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2582033002: Remove target that cause ambiguity with downstream targets. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove target that cause ambiguity with downstream targets. BUG=666375 Committed: https://crrev.com/737df8713d8ff987eeed283dfc357a616f45ef07 Cr-Commit-Position: refs/heads/master@{#439120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M ios/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/app/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D ios/showcase/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sdefresne
Please take a look.
4 years ago (2016-12-16 15:31:07 UTC) #3
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-16 15:34:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582033002/1
4 years ago (2016-12-16 15:36:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 16:25:28 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-16 16:28:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/737df8713d8ff987eeed283dfc357a616f45ef07
Cr-Commit-Position: refs/heads/master@{#439120}

Powered by Google App Engine
This is Rietveld 408576698